Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log with warning if no extension found #4975

Closed
wants to merge 1 commit into from

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Aug 30, 2019

which introduced by #1837 and fix #2827
eg:

    ApplicationConfig applicationConfig = new ApplicationConfig();
    applicationConfig.setName("demo-app");
    applicationConfig.setLogger("slf4j");

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

which introduced by apache#1837 and fix apache#2827
eg:

```
    ApplicationConfig applicationConfig = new ApplicationConfig();
    applicationConfig.setName("demo-app");
    applicationConfig.setLogger("slf4j");
```
@codecov-io
Copy link

Codecov Report

Merging #4975 into master will decrease coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4975      +/-   ##
============================================
- Coverage     64.03%   63.93%   -0.11%     
+ Complexity      453      450       -3     
============================================
  Files           769      769              
  Lines         33160    33162       +2     
  Branches       5230     5232       +2     
============================================
- Hits          21233    21201      -32     
- Misses         9511     9534      +23     
- Partials       2416     2427      +11
Impacted Files Coverage Δ Complexity Δ
...onfig/spring/extension/SpringExtensionFactory.java 81.39% <50%> (+0.9%) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 65.85% <0%> (-17.08%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 53.84% <0%> (-7.7%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9bf2a...b8a2353. Read the comment docs.

@beiwei30
Copy link
Member

beiwei30 commented Sep 3, 2019

@lonre This is not an issue. The exception stack trace is print out only because the logging level is set to DEBUG.

@beiwei30 beiwei30 closed this Sep 3, 2019
@lonre
Copy link
Contributor Author

lonre commented Sep 3, 2019

@lonre This is not an issue. The exception stack trace is print out only because the logging level is set to DEBUG.

Hi, @beiwei30 chould you please check this

#2827 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.6.5版本报WARN
3 participants