Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace hardcode with regex pattern #4810

Merged
merged 1 commit into from
Aug 16, 2019
Merged

replace hardcode with regex pattern #4810

merged 1 commit into from
Aug 16, 2019

Conversation

anLA7856
Copy link
Contributor

remove some hardcode

@codecov-io
Copy link

Codecov Report

Merging #4810 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4810      +/-   ##
============================================
- Coverage     63.92%   63.89%   -0.03%     
+ Complexity      451      449       -2     
============================================
  Files           769      769              
  Lines         33171    33172       +1     
  Branches       5229     5229              
============================================
- Hits          21204    21195       -9     
- Misses         9547     9553       +6     
- Partials       2420     2424       +4
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/config/AbstractInterfaceConfig.java 71.59% <100%> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
.../remoting/transport/netty4/NettyClientHandler.java 61.4% <0%> (-7.02%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-2.18%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 65.09% <0%> (-1.89%) 0% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897709b...1874823. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the pull request.

@ralf0131 ralf0131 merged commit 10ef042 into apache:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants