-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge exceptions, remove redundant interface implementations #4730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nice clean up:)
final TServer thriftServer = new TThreadedSelectorServer(tArgs); | ||
serverMap.put(url.getAddress(),thriftServer); | ||
final TServer thriftServer = new TThreadedSelectorServer(tArgs); | ||
serverMap.put(url.getAddress(), thriftServer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a method(such as a pattern?) to make all those formatter done? I found many this kind of problems.
Like
dubbo/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/CommandContextFactory.java
Line 25 in 87703ad
return new CommandContext(commandName,args,isHttp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different protocols have different implementations, and I don't think there is a need to use design patterns here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the lack of space here, not design pattern, but code format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, understand the mistake, modify it later.
Codecov Report
@@ Coverage Diff @@
## master #4730 +/- ##
============================================
- Coverage 59.22% 59.11% -0.11%
- Complexity 503 527 +24
============================================
Files 1076 1076
Lines 43410 43410
Branches 6339 6340 +1
============================================
- Hits 25709 25662 -47
- Misses 14858 14906 +48
+ Partials 2843 2842 -1
Continue to review full report at Codecov.
|
|
# Conflicts: # dubbo-rpc/dubbo-rpc-native-thrift/src/main/java/org/apache/dubbo/rpc/protocol/nativethrift/ThriftProtocol.java
@CrazyHZM Hi, pls resolve conficts. |
# Conflicts: # dubbo-rpc/dubbo-rpc-native-thrift/src/main/java/org/apache/dubbo/rpc/protocol/nativethrift/ThriftProtocol.java
@AlbumenJ done |
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.