Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3994]: Need to enhance DecodeableRpcResult error message #3995

Merged
merged 1 commit into from
May 10, 2019
Merged

[DUBBO-3994]: Need to enhance DecodeableRpcResult error message #3995

merged 1 commit into from
May 10, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented May 8, 2019

What is the purpose of the change

fix #3994

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3995 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3995      +/-   ##
============================================
+ Coverage     63.66%   63.66%   +<.01%     
+ Complexity      566      563       -3     
============================================
  Files           748      748              
  Lines         32309    32351      +42     
  Branches       5134     5151      +17     
============================================
+ Hits          20569    20596      +27     
- Misses         9381     9393      +12     
- Partials       2359     2362       +3
Impacted Files Coverage Δ Complexity Δ
.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java 66.17% <0%> (ø) 0 <0> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-11.85%) 16% <0%> (-2%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 65.21% <0%> (-6.53%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 69.64% <0%> (-3.58%) 8% <0%> (-1%)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.46% <0%> (-0.69%) 0% <0%> (ø)
...src/main/java/org/apache/dubbo/common/Version.java 62.22% <0%> (-0.15%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.85% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 48.95% <0%> (+1.04%) 0% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 69.68% <0%> (+1.8%) 0% <0%> (ø) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455d29a...5f9fba2. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 09d8a6e into apache:master May 10, 2019
@caojiele caojiele mentioned this pull request May 10, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to enhance DecodeableRpcResult error message
3 participants