Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serializationConstant #3981

Closed
wants to merge 1 commit into from

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented May 6, 2019

What is the purpose of the change

Constants is too large, divided into module Constants to manage constants
follow #3967
add SerializationConstants

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3981 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3981      +/-   ##
============================================
+ Coverage     63.68%   63.74%   +0.06%     
  Complexity       71       71              
============================================
  Files           743      744       +1     
  Lines         32125    32126       +1     
  Branches       5120     5120              
============================================
+ Hits          20458    20480      +22     
+ Misses         9322     9296      -26     
- Partials       2345     2350       +5
Impacted Files Coverage Δ Complexity Δ
.../factory/annotation/AnnotationBeanNameBuilder.java 96.96% <ø> (ø) 0 <0> (ø) ⬇️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 96.96% <ø> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 67.74% <ø> (ø) 0 <0> (ø) ⬇️
...he/dubbo/rpc/protocol/ProtocolListenerWrapper.java 89.47% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/ProtocolConfig.java 92.85% <ø> (ø) 0 <0> (ø) ⬇️
...ookeeper/support/AbstractZookeeperTransporter.java 85% <ø> (ø) 0 <0> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.88% <ø> (ø) 0 <0> (ø) ⬇️
.../rpc/cluster/router/condition/ConditionRouter.java 68.05% <ø> (ø) 0 <0> (ø) ⬇️
...onfig/spring/schema/DubboBeanDefinitionParser.java 67.27% <ø> (ø) 0 <0> (ø) ⬇️
.../org/apache/dubbo/config/MetadataReportConfig.java 92.3% <ø> (ø) 0 <0> (ø) ⬇️
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77df9d7...b014bfb. Read the comment docs.

Copy link
Contributor

@Leishunyu Leishunyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beiwei30
Copy link
Member

beiwei30 commented May 9, 2019

it is indeed a good idea, but it is incomplete solution. Instead, we should examine Constants throughly and classify all constants in it carefully. What I suggest is we should divide this work into four steps:

  1. Examine Constants.java and classify throughly.
  2. Introduce new sub package 'constants' as what you did, and introduce new Constants classes in it.
  3. Start to switch from old Constants to new Constants
  4. Remove the old Constants.

I will file one new issue to track this work.

@beiwei30 beiwei30 closed this May 9, 2019
@beiwei30
Copy link
Member

beiwei30 commented May 9, 2019

It's tracked now by #3137. I will do the step 1 first, after that, we could start to divide the works for step2 and step3

@CrazyHZM
Copy link
Member Author

CrazyHZM commented May 9, 2019

This is a good plan. After your first step is completed, I will participate in the follow-up work.

@beiwei30
Copy link
Member

beiwei30 commented May 9, 2019

sure, thanks.

@CrazyHZM CrazyHZM deleted the serializationConstant branch April 27, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants