Simplify the code of StringUtils to make it more graceful. #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2740 +/- ##
=========================================
+ Coverage 62.38% 63.5% +1.12%
=========================================
Files 598 577 -21
Lines 27911 25920 -1991
Branches 4828 4541 -287
=========================================
- Hits 17412 16461 -951
+ Misses 8233 7299 -934
+ Partials 2266 2160 -106
Continue to review full report at Codecov.
|
|
great work, thanks. |
CrazyHZM
added a commit
to CrazyHZM/dubbo
that referenced
this pull request
Dec 6, 2018
* combine test coverage report (apache#2643) * Optimize ut for serialization model. (apache#2632) * 1. Integrate the unit test of the serialization module, code reuse. 2. Remove redundant unit tests and pojo classes. 3. Remove the useless pojo class in the common module. * fix ci fail * fix ci fail * fix ci fail * fix ci fail * remove author info * prototype for issue2570 (apache#2640) * apache#2570: dubbo all in one fail to start from a tomcat server when spring framework is absent * add comments and fix unit test * add license header * update comments in unit tests * [Dubbo -fix annotation bug] Fix @reference bug (apache#2649) It's fine. * Merge pull request apache#2656, make sure serialization exception sends back to consumer to preventing endless waiting. Fixes apache#1903: Our customized serialization id exceeds the maximum limit, now it cannot work on 2.6.2 anymore. * apache#1903: supplemental change (apache#2666) * Optimize the doSelect method of RandomLoadBalance to reduce the times of invoke of the getWeight method of the AbstractLoadBalance (apache#2597) * 解决与quartz集成报错问题 (apache#2677) quartz初始化的Bean没有beanName，beanName=null，走这段代码的时候报空指针了。 org.springframework.boot.autoconfigure.quartz.AutowireCapableBeanJobFactory类的createJobInstance方法中使用this.beanFactory.initializeBean(jobInstance, null);初始化的Bean，其beanName=null。 * Code format (apache#2662) * NullPointerException * code rule * Merge pull request#2679, consumer throws RpcException when RegistryDirectory notify in high QPS. Fixes apache#2016 * remove ServiceClassHolder and use the ApplicationModel replacedly (apache#2646) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * [Dubbo-1983] Support Protobuf Serialization (apache#2618) * finish support protobuf * polish * fix code review * use the general test for serialization * Smooth Round Robin selection (apache#2650) * enhance pull request 2618 (apache#2691) * enhance pull request 2618 * move spi file into the right directory * ignore protostuff test case * make unit test pass, support Time type * fix useless imports issue * add license header * fix typo error in FAQ (apache#2684) fix typo error in FAQ * remove author info for RoundRobinLoadBalance (apache#2697) * fix pom for protostuff serialization (apache#2700) * Optimize REGISTRIES field in AbstractRegistryFactory. (apache#2703) * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * [version 2.7.0]remove the StaticContext class and refactor the code related to Async (apache#2688) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * remove StaticContext * remove the unused imported classes of ReferenceConfig * fix NPE of ConsumerModel * fix the failed testcase of AbstractClusterInvokerTest * [Dubbo] #PR2688 to fix the review issues * Optimize heartbeat and reconnect task. (apache#2658) * Optimize heartbeat and reconnect task. 1.Use hashedWheelTimer. 2.Distinguish between reconnect and heartbeat. 3.Increase inspection cycle. * fix ci fail. * fix ci fail. * fix ci fail. * polish the code for pull request 2658: Optimize heartbeat and reconnect task (apache#2709) * 重构 ServiceBean 的 isDelay 方法，使其更符合语义 (apache#2686) * Refactor method isDelay of ServiceBean to fix the wrong meaning of the method * Remove unnecessary method isDelay of ServiceBean * 【Unit Test】FailbackRegistry Test: recover method (apache#2591) * FailbackRegistry Test: recover method * fix the type error, and use CountDownLatch await method to fix the unstable problom * trigger the travis ci test retry * trigger the code static check again * replace ServiceAnnotationBeanPostProcessor log.isInfoEnabled->log.isWarnEnabled (apache#2712) simplify ExtensionLoader code segment * [Dubbo-2678][For Master] Add ability to turn off SPI auto injection, special support for Object type. (apache#2682) * Add ability to turn off SPI auto injection, special support for generic Object type injection. * Change Inject to AutoInject since it's main purpose is to turn off auto-injection. * disable is redundant in DisableInject annotation * Merge pull request apache#2725, problems of graceful shutdown in 2.6.3 and some recommendation. * enhance comments (apache#2735) * code format (apache#2730) * NullPointerException * code rule * code rule * Close all servers/ports after tests finish (apache#2741) * Simplify the code of StringUtils to make it more graceful. (apache#2740) * Simplify the code of StringUtils to make it more graceful. * Add Apache license * Add 'forks' config into xml config (apache#2568) * Add forks into xml config. * Add forks into xml config. * Add forks into xml config. * fix typo (apache#2747) * [DUBBO-2489] MockClusterInvoker provides local forced mock，I tested it locally, but it doesn't work (apache#2742) * apache#2748: Provider should disable mock configuration (apache#2749) * Fix the bug that ReferenceBean refers service more than once when debugging. (apache#2754) note: please visit http://t.cn/EAhta27 for more detail. * Close all servers/ports after tests finish (apache#2755) * add checkstyle rule to check import order (apache#2745) * Changing URL so tests can run in any order (apache#2760) * [Dubbo-2353]fix Invalid property 'interfaceName' of bean class [org.apache.dubbo.config.spring.ServiceBean]apache#2353 (apache#2418) * add getter and setter for ServiceConfig's interfaceName property#2353 * add interfaceName to ignoreAttributeNames and change the unit test * delete the demo source code and update the unit test * unchange ServiceConfig * update unit test * update unit test * apache#2762: [Dubbo - qos-http] stopServer should be invoked ? (apache#2767) * apache#2777: heartbeat threads blocks process shutdown (apache#2778) Fix heartbeat threads blocks process shutdown because its hashed-wheel-timer is non-daemon thread. * oschina vote (apache#2786) * fix typo (apache#2791) Fix typo confilict -> conflict * improvement on Parameters and CollectionUtils (apache#2790) Use CollectionUtils.toStringMap to reduce duplicate code in Parameters, and use Java 8 type inference for collections. * [REFACTOR]:[fix typo] (apache#2804) fix typos * [Dubbo-2798]fix apporiate NotWritablePropertyException (apache#2800) fix apache#2798 . 'propertyname in java donot contain '-' but camel format'. * [Dubbo-2758] Adding dependency on dubbo-remoting-mina for tests in dubbo-rpc-dubbo (apache#2797) * Adding dependency on dubbo-remoting-mina so DubboProtocolTest.testDubboProtocolWithMina is no longer flaky * Changing port number to ensure new server/client created for test * modify dubbo version to 2.6.5 * fix typo of field (apache#2825) * [Dubbo-2845] Fix OOM in UT testSelectByWeight (apache#2845) (apache#2846) Fix OOM Exception generated during UT * Fix UT failed on windows with FileNetworkerTest (apache#2848) Fix FileNetworkerTest failure * Update README.md remove oschina vote * fixed typo of variable (apache#2875) fixed type of variable * Remove unnessesary code in RegistryDirectory#doList (apache#2861) * remove unnessesary code * remove unused import * add some ScriptRoute test case (apache#2879) * add router test case * correct an error word * remove the duplicate superclass of TagRouter and ConditionRouter (apache#2885) Remove the class ConditionRouter and TagRouter implement duplicate superclass Comparable
CrazyHZM
added a commit
to CrazyHZM/dubbo
that referenced
this pull request
Dec 6, 2018
* combine test coverage report (apache#2643) * Optimize ut for serialization model. (apache#2632) * 1. Integrate the unit test of the serialization module, code reuse. 2. Remove redundant unit tests and pojo classes. 3. Remove the useless pojo class in the common module. * fix ci fail * fix ci fail * fix ci fail * fix ci fail * remove author info * prototype for issue2570 (apache#2640) * apache#2570: dubbo all in one fail to start from a tomcat server when spring framework is absent * add comments and fix unit test * add license header * update comments in unit tests * [Dubbo -fix annotation bug] Fix @reference bug (apache#2649) It's fine. * Merge pull request apache#2656, make sure serialization exception sends back to consumer to preventing endless waiting. Fixes apache#1903: Our customized serialization id exceeds the maximum limit, now it cannot work on 2.6.2 anymore. * apache#1903: supplemental change (apache#2666) * Optimize the doSelect method of RandomLoadBalance to reduce the times of invoke of the getWeight method of the AbstractLoadBalance (apache#2597) * 解决与quartz集成报错问题 (apache#2677) quartz初始化的Bean没有beanName，beanName=null，走这段代码的时候报空指针了。 org.springframework.boot.autoconfigure.quartz.AutowireCapableBeanJobFactory类的createJobInstance方法中使用this.beanFactory.initializeBean(jobInstance, null);初始化的Bean，其beanName=null。 * Code format (apache#2662) * NullPointerException * code rule * Merge pull request#2679, consumer throws RpcException when RegistryDirectory notify in high QPS. Fixes apache#2016 * remove ServiceClassHolder and use the ApplicationModel replacedly (apache#2646) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * [Dubbo-1983] Support Protobuf Serialization (apache#2618) * finish support protobuf * polish * fix code review * use the general test for serialization * Smooth Round Robin selection (apache#2650) * enhance pull request 2618 (apache#2691) * enhance pull request 2618 * move spi file into the right directory * ignore protostuff test case * make unit test pass, support Time type * fix useless imports issue * add license header * fix typo error in FAQ (apache#2684) fix typo error in FAQ * remove author info for RoundRobinLoadBalance (apache#2697) * fix pom for protostuff serialization (apache#2700) * Optimize REGISTRIES field in AbstractRegistryFactory. (apache#2703) * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * [version 2.7.0]remove the StaticContext class and refactor the code related to Async (apache#2688) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * remove StaticContext * remove the unused imported classes of ReferenceConfig * fix NPE of ConsumerModel * fix the failed testcase of AbstractClusterInvokerTest * [Dubbo] #PR2688 to fix the review issues * Optimize heartbeat and reconnect task. (apache#2658) * Optimize heartbeat and reconnect task. 1.Use hashedWheelTimer. 2.Distinguish between reconnect and heartbeat. 3.Increase inspection cycle. * fix ci fail. * fix ci fail. * fix ci fail. * polish the code for pull request 2658: Optimize heartbeat and reconnect task (apache#2709) * 重构 ServiceBean 的 isDelay 方法，使其更符合语义 (apache#2686) * Refactor method isDelay of ServiceBean to fix the wrong meaning of the method * Remove unnecessary method isDelay of ServiceBean * 【Unit Test】FailbackRegistry Test: recover method (apache#2591) * FailbackRegistry Test: recover method * fix the type error, and use CountDownLatch await method to fix the unstable problom * trigger the travis ci test retry * trigger the code static check again * replace ServiceAnnotationBeanPostProcessor log.isInfoEnabled->log.isWarnEnabled (apache#2712) simplify ExtensionLoader code segment * [Dubbo-2678][For Master] Add ability to turn off SPI auto injection, special support for Object type. (apache#2682) * Add ability to turn off SPI auto injection, special support for generic Object type injection. * Change Inject to AutoInject since it's main purpose is to turn off auto-injection. * disable is redundant in DisableInject annotation * Merge pull request apache#2725, problems of graceful shutdown in 2.6.3 and some recommendation. * enhance comments (apache#2735) * code format (apache#2730) * NullPointerException * code rule * code rule * Close all servers/ports after tests finish (apache#2741) * Simplify the code of StringUtils to make it more graceful. (apache#2740) * Simplify the code of StringUtils to make it more graceful. * Add Apache license * Add 'forks' config into xml config (apache#2568) * Add forks into xml config. * Add forks into xml config. * Add forks into xml config. * fix typo (apache#2747) * [DUBBO-2489] MockClusterInvoker provides local forced mock，I tested it locally, but it doesn't work (apache#2742) * apache#2748: Provider should disable mock configuration (apache#2749) * Fix the bug that ReferenceBean refers service more than once when debugging. (apache#2754) note: please visit http://t.cn/EAhta27 for more detail. * Close all servers/ports after tests finish (apache#2755) * add checkstyle rule to check import order (apache#2745) * Changing URL so tests can run in any order (apache#2760) * [Dubbo-2353]fix Invalid property 'interfaceName' of bean class [org.apache.dubbo.config.spring.ServiceBean]apache#2353 (apache#2418) * add getter and setter for ServiceConfig's interfaceName property#2353 * add interfaceName to ignoreAttributeNames and change the unit test * delete the demo source code and update the unit test * unchange ServiceConfig * update unit test * update unit test * apache#2762: [Dubbo - qos-http] stopServer should be invoked ? (apache#2767) * apache#2777: heartbeat threads blocks process shutdown (apache#2778) Fix heartbeat threads blocks process shutdown because its hashed-wheel-timer is non-daemon thread. * oschina vote (apache#2786) * fix typo (apache#2791) Fix typo confilict -> conflict * improvement on Parameters and CollectionUtils (apache#2790) Use CollectionUtils.toStringMap to reduce duplicate code in Parameters, and use Java 8 type inference for collections. * [REFACTOR]:[fix typo] (apache#2804) fix typos * [Dubbo-2798]fix apporiate NotWritablePropertyException (apache#2800) fix apache#2798 . 'propertyname in java donot contain '-' but camel format'. * [Dubbo-2758] Adding dependency on dubbo-remoting-mina for tests in dubbo-rpc-dubbo (apache#2797) * Adding dependency on dubbo-remoting-mina so DubboProtocolTest.testDubboProtocolWithMina is no longer flaky * Changing port number to ensure new server/client created for test * modify dubbo version to 2.6.5 * fix typo of field (apache#2825) * [Dubbo-2845] Fix OOM in UT testSelectByWeight (apache#2845) (apache#2846) Fix OOM Exception generated during UT * Fix UT failed on windows with FileNetworkerTest (apache#2848) Fix FileNetworkerTest failure * Update README.md remove oschina vote * fixed typo of variable (apache#2875) fixed type of variable * Remove unnessesary code in RegistryDirectory#doList (apache#2861) * remove unnessesary code * remove unused import * add some ScriptRoute test case (apache#2879) * add router test case * correct an error word * remove the duplicate superclass of TagRouter and ConditionRouter (apache#2885) Remove the class ConditionRouter and TagRouter implement duplicate superclass Comparable
CrazyHZM
added a commit
to CrazyHZM/dubbo
that referenced
this pull request
Dec 6, 2018
* combine test coverage report (apache#2643) * Optimize ut for serialization model. (apache#2632) * 1. Integrate the unit test of the serialization module, code reuse. 2. Remove redundant unit tests and pojo classes. 3. Remove the useless pojo class in the common module. * fix ci fail * fix ci fail * fix ci fail * fix ci fail * remove author info * prototype for issue2570 (apache#2640) * apache#2570: dubbo all in one fail to start from a tomcat server when spring framework is absent * add comments and fix unit test * add license header * update comments in unit tests * [Dubbo -fix annotation bug] Fix @reference bug (apache#2649) It's fine. * Merge pull request apache#2656, make sure serialization exception sends back to consumer to preventing endless waiting. Fixes apache#1903: Our customized serialization id exceeds the maximum limit, now it cannot work on 2.6.2 anymore. * apache#1903: supplemental change (apache#2666) * Optimize the doSelect method of RandomLoadBalance to reduce the times of invoke of the getWeight method of the AbstractLoadBalance (apache#2597) * 解决与quartz集成报错问题 (apache#2677) quartz初始化的Bean没有beanName，beanName=null，走这段代码的时候报空指针了。 org.springframework.boot.autoconfigure.quartz.AutowireCapableBeanJobFactory类的createJobInstance方法中使用this.beanFactory.initializeBean(jobInstance, null);初始化的Bean，其beanName=null。 * Code format (apache#2662) * NullPointerException * code rule * Merge pull request#2679, consumer throws RpcException when RegistryDirectory notify in high QPS. Fixes apache#2016 * remove ServiceClassHolder and use the ApplicationModel replacedly (apache#2646) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * [Dubbo-1983] Support Protobuf Serialization (apache#2618) * finish support protobuf * polish * fix code review * use the general test for serialization * Smooth Round Robin selection (apache#2650) * enhance pull request 2618 (apache#2691) * enhance pull request 2618 * move spi file into the right directory * ignore protostuff test case * make unit test pass, support Time type * fix useless imports issue * add license header * fix typo error in FAQ (apache#2684) fix typo error in FAQ * remove author info for RoundRobinLoadBalance (apache#2697) * fix pom for protostuff serialization (apache#2700) * Optimize REGISTRIES field in AbstractRegistryFactory. (apache#2703) * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * [version 2.7.0]remove the StaticContext class and refactor the code related to Async (apache#2688) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * remove StaticContext * remove the unused imported classes of ReferenceConfig * fix NPE of ConsumerModel * fix the failed testcase of AbstractClusterInvokerTest * [Dubbo] #PR2688 to fix the review issues * Optimize heartbeat and reconnect task. (apache#2658) * Optimize heartbeat and reconnect task. 1.Use hashedWheelTimer. 2.Distinguish between reconnect and heartbeat. 3.Increase inspection cycle. * fix ci fail. * fix ci fail. * fix ci fail. * polish the code for pull request 2658: Optimize heartbeat and reconnect task (apache#2709) * 重构 ServiceBean 的 isDelay 方法，使其更符合语义 (apache#2686) * Refactor method isDelay of ServiceBean to fix the wrong meaning of the method * Remove unnecessary method isDelay of ServiceBean * 【Unit Test】FailbackRegistry Test: recover method (apache#2591) * FailbackRegistry Test: recover method * fix the type error, and use CountDownLatch await method to fix the unstable problom * trigger the travis ci test retry * trigger the code static check again * replace ServiceAnnotationBeanPostProcessor log.isInfoEnabled->log.isWarnEnabled (apache#2712) simplify ExtensionLoader code segment * [Dubbo-2678][For Master] Add ability to turn off SPI auto injection, special support for Object type. (apache#2682) * Add ability to turn off SPI auto injection, special support for generic Object type injection. * Change Inject to AutoInject since it's main purpose is to turn off auto-injection. * disable is redundant in DisableInject annotation * Merge pull request apache#2725, problems of graceful shutdown in 2.6.3 and some recommendation. * enhance comments (apache#2735) * code format (apache#2730) * NullPointerException * code rule * code rule * Close all servers/ports after tests finish (apache#2741) * Simplify the code of StringUtils to make it more graceful. (apache#2740) * Simplify the code of StringUtils to make it more graceful. * Add Apache license * Add 'forks' config into xml config (apache#2568) * Add forks into xml config. * Add forks into xml config. * Add forks into xml config. * fix typo (apache#2747) * [DUBBO-2489] MockClusterInvoker provides local forced mock，I tested it locally, but it doesn't work (apache#2742) * apache#2748: Provider should disable mock configuration (apache#2749) * Fix the bug that ReferenceBean refers service more than once when debugging. (apache#2754) note: please visit http://t.cn/EAhta27 for more detail. * Close all servers/ports after tests finish (apache#2755) * add checkstyle rule to check import order (apache#2745) * Changing URL so tests can run in any order (apache#2760) * [Dubbo-2353]fix Invalid property 'interfaceName' of bean class [org.apache.dubbo.config.spring.ServiceBean]apache#2353 (apache#2418) * add getter and setter for ServiceConfig's interfaceName property#2353 * add interfaceName to ignoreAttributeNames and change the unit test * delete the demo source code and update the unit test * unchange ServiceConfig * update unit test * update unit test * apache#2762: [Dubbo - qos-http] stopServer should be invoked ? (apache#2767) * apache#2777: heartbeat threads blocks process shutdown (apache#2778) Fix heartbeat threads blocks process shutdown because its hashed-wheel-timer is non-daemon thread. * oschina vote (apache#2786) * fix typo (apache#2791) Fix typo confilict -> conflict * improvement on Parameters and CollectionUtils (apache#2790) Use CollectionUtils.toStringMap to reduce duplicate code in Parameters, and use Java 8 type inference for collections. * [REFACTOR]:[fix typo] (apache#2804) fix typos * [Dubbo-2798]fix apporiate NotWritablePropertyException (apache#2800) fix apache#2798 . 'propertyname in java donot contain '-' but camel format'. * [Dubbo-2758] Adding dependency on dubbo-remoting-mina for tests in dubbo-rpc-dubbo (apache#2797) * Adding dependency on dubbo-remoting-mina so DubboProtocolTest.testDubboProtocolWithMina is no longer flaky * Changing port number to ensure new server/client created for test * modify dubbo version to 2.6.5 * fix typo of field (apache#2825) * [Dubbo-2845] Fix OOM in UT testSelectByWeight (apache#2845) (apache#2846) Fix OOM Exception generated during UT * Fix UT failed on windows with FileNetworkerTest (apache#2848) Fix FileNetworkerTest failure * Update README.md remove oschina vote * fixed typo of variable (apache#2875) fixed type of variable * Remove unnessesary code in RegistryDirectory#doList (apache#2861) * remove unnessesary code * remove unused import * add some ScriptRoute test case (apache#2879) * add router test case * correct an error word * remove the duplicate superclass of TagRouter and ConditionRouter (apache#2885) Remove the class ConditionRouter and TagRouter implement duplicate superclass Comparable
CrazyHZM
added a commit
to CrazyHZM/dubbo
that referenced
this pull request
Dec 6, 2018
* combine test coverage report (apache#2643) * Optimize ut for serialization model. (apache#2632) * 1. Integrate the unit test of the serialization module, code reuse. 2. Remove redundant unit tests and pojo classes. 3. Remove the useless pojo class in the common module. * fix ci fail * fix ci fail * fix ci fail * fix ci fail * remove author info * prototype for issue2570 (apache#2640) * apache#2570: dubbo all in one fail to start from a tomcat server when spring framework is absent * add comments and fix unit test * add license header * update comments in unit tests * [Dubbo -fix annotation bug] Fix @reference bug (apache#2649) It's fine. * Merge pull request apache#2656, make sure serialization exception sends back to consumer to preventing endless waiting. Fixes apache#1903: Our customized serialization id exceeds the maximum limit, now it cannot work on 2.6.2 anymore. * apache#1903: supplemental change (apache#2666) * Optimize the doSelect method of RandomLoadBalance to reduce the times of invoke of the getWeight method of the AbstractLoadBalance (apache#2597) * 解决与quartz集成报错问题 (apache#2677) quartz初始化的Bean没有beanName，beanName=null，走这段代码的时候报空指针了。 org.springframework.boot.autoconfigure.quartz.AutowireCapableBeanJobFactory类的createJobInstance方法中使用this.beanFactory.initializeBean(jobInstance, null);初始化的Bean，其beanName=null。 * Code format (apache#2662) * NullPointerException * code rule * Merge pull request#2679, consumer throws RpcException when RegistryDirectory notify in high QPS. Fixes apache#2016 * remove ServiceClassHolder and use the ApplicationModel replacedly (apache#2646) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * [Dubbo-1983] Support Protobuf Serialization (apache#2618) * finish support protobuf * polish * fix code review * use the general test for serialization * Smooth Round Robin selection (apache#2650) * enhance pull request 2618 (apache#2691) * enhance pull request 2618 * move spi file into the right directory * ignore protostuff test case * make unit test pass, support Time type * fix useless imports issue * add license header * fix typo error in FAQ (apache#2684) fix typo error in FAQ * remove author info for RoundRobinLoadBalance (apache#2697) * fix pom for protostuff serialization (apache#2700) * Optimize REGISTRIES field in AbstractRegistryFactory. (apache#2703) * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的问题。所以这里建议使用hashmap * [version 2.7.0]remove the StaticContext class and refactor the code related to Async (apache#2688) * [Dubbo] move the classes of model from config to rpc-api for reusing * remove ServiceClassHolder and use the ApplicationModel replacedly * [Dubbo] delete the unused imported of ApplicationModel * Update dubbo-demo-consumer.xml this commits is no need to commit to remote repo. * remove StaticContext * remove the unused imported classes of ReferenceConfig * fix NPE of ConsumerModel * fix the failed testcase of AbstractClusterInvokerTest * [Dubbo] #PR2688 to fix the review issues * Optimize heartbeat and reconnect task. (apache#2658) * Optimize heartbeat and reconnect task. 1.Use hashedWheelTimer. 2.Distinguish between reconnect and heartbeat. 3.Increase inspection cycle. * fix ci fail. * fix ci fail. * fix ci fail. * polish the code for pull request 2658: Optimize heartbeat and reconnect task (apache#2709) * 重构 ServiceBean 的 isDelay 方法，使其更符合语义 (apache#2686) * Refactor method isDelay of ServiceBean to fix the wrong meaning of the method * Remove unnecessary method isDelay of ServiceBean * 【Unit Test】FailbackRegistry Test: recover method (apache#2591) * FailbackRegistry Test: recover method * fix the type error, and use CountDownLatch await method to fix the unstable problom * trigger the travis ci test retry * trigger the code static check again * replace ServiceAnnotationBeanPostProcessor log.isInfoEnabled->log.isWarnEnabled (apache#2712) simplify ExtensionLoader code segment * [Dubbo-2678][For Master] Add ability to turn off SPI auto injection, special support for Object type. (apache#2682) * Add ability to turn off SPI auto injection, special support for generic Object type injection. * Change Inject to AutoInject since it's main purpose is to turn off auto-injection. * disable is redundant in DisableInject annotation * Merge pull request apache#2725, problems of graceful shutdown in 2.6.3 and some recommendation. * enhance comments (apache#2735) * code format (apache#2730) * NullPointerException * code rule * code rule * Close all servers/ports after tests finish (apache#2741) * Simplify the code of StringUtils to make it more graceful. (apache#2740) * Simplify the code of StringUtils to make it more graceful. * Add Apache license * Add 'forks' config into xml config (apache#2568) * Add forks into xml config. * Add forks into xml config. * Add forks into xml config. * fix typo (apache#2747) * [DUBBO-2489] MockClusterInvoker provides local forced mock，I tested it locally, but it doesn't work (apache#2742) * apache#2748: Provider should disable mock configuration (apache#2749) * Fix the bug that ReferenceBean refers service more than once when debugging. (apache#2754) note: please visit http://t.cn/EAhta27 for more detail. * Close all servers/ports after tests finish (apache#2755) * add checkstyle rule to check import order (apache#2745) * Changing URL so tests can run in any order (apache#2760) * [Dubbo-2353]fix Invalid property 'interfaceName' of bean class [org.apache.dubbo.config.spring.ServiceBean]apache#2353 (apache#2418) * add getter and setter for ServiceConfig's interfaceName property#2353 * add interfaceName to ignoreAttributeNames and change the unit test * delete the demo source code and update the unit test * unchange ServiceConfig * update unit test * update unit test * apache#2762: [Dubbo - qos-http] stopServer should be invoked ? (apache#2767) * apache#2777: heartbeat threads blocks process shutdown (apache#2778) Fix heartbeat threads blocks process shutdown because its hashed-wheel-timer is non-daemon thread. * oschina vote (apache#2786) * fix typo (apache#2791) Fix typo confilict -> conflict * improvement on Parameters and CollectionUtils (apache#2790) Use CollectionUtils.toStringMap to reduce duplicate code in Parameters, and use Java 8 type inference for collections. * [REFACTOR]:[fix typo] (apache#2804) fix typos * [Dubbo-2798]fix apporiate NotWritablePropertyException (apache#2800) fix apache#2798 . 'propertyname in java donot contain '-' but camel format'. * [Dubbo-2758] Adding dependency on dubbo-remoting-mina for tests in dubbo-rpc-dubbo (apache#2797) * Adding dependency on dubbo-remoting-mina so DubboProtocolTest.testDubboProtocolWithMina is no longer flaky * Changing port number to ensure new server/client created for test * modify dubbo version to 2.6.5 * fix typo of field (apache#2825) * [Dubbo-2845] Fix OOM in UT testSelectByWeight (apache#2845) (apache#2846) Fix OOM Exception generated during UT * Fix UT failed on windows with FileNetworkerTest (apache#2848) Fix FileNetworkerTest failure * Update README.md remove oschina vote * fixed typo of variable (apache#2875) fixed type of variable * Remove unnessesary code in RegistryDirectory#doList (apache#2861) * remove unnessesary code * remove unused import * add some ScriptRoute test case (apache#2879) * add router test case * correct an error word * remove the duplicate superclass of TagRouter and ConditionRouter (apache#2885) Remove the class ConditionRouter and TagRouter implement duplicate superclass Comparable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Simplify the code of StringUtils to make it more graceful.
Brief changelog
Modified files:
dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
dubbo-common/src/test/java/org/apache/dubbo/common/utils/StringUtilsTest.java
New Files:
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ArrayUtils.java
dubbo-common/src/test/java/org/apache/dubbo/common/utils/ArrayUtilsTest.java