Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue: [2218] When using telnet "invoke" method, if there is a [n… #2231

Closed
wants to merge 1 commit into from

Conversation

elvis9xu163
Copy link

@elvis9xu163 elvis9xu163 commented Aug 13, 2018

…ull] param, the response always be [null] #2218

What is the purpose of the change

issue fix

Brief changelog

fix issue: [2218] When using telnet "invoke" method, if there is a [null] param, the response always be [null] #2218

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@elvis9xu163
Copy link
Author

I fix the issue based on last release version, so there are many conflicts and hard to resolve. now i fix again based on master.

@diecui1202 diecui1202 closed this Aug 15, 2018
@diecui1202 diecui1202 reopened this Aug 15, 2018
@diecui1202
Copy link

@elvis9xu163 Maybe you need to consider the primary type.

@diecui1202
Copy link

#2273

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8beeb64). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2231   +/-   ##
=========================================
  Coverage          ?   54.83%           
  Complexity        ?     5192           
=========================================
  Files             ?      569           
  Lines             ?    25093           
  Branches          ?     4459           
=========================================
  Hits              ?    13759           
  Misses            ?     9290           
  Partials          ?     2044
Impacted Files Coverage Δ Complexity Δ
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 54.32% <0%> (ø) 13 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8beeb64...bb58889. Read the comment docs.

@diecui1202
Copy link

@elvis9xu163 I'll close this PR, we can take more discussion on #2273

@diecui1202 diecui1202 closed this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants