Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2188 ConsistentHashLoadBalance selectForKey can optimization #2190

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

huangyunbin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2190 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2190      +/-   ##
============================================
+ Coverage     54.25%   54.28%   +0.02%     
  Complexity     5121     5121              
============================================
  Files           569      569              
  Lines         25031    25031              
  Branches       4456     4456              
============================================
+ Hits          13581    13587       +6     
+ Misses         9415     9408       -7     
- Partials       2035     2036       +1
Impacted Files Coverage Δ Complexity Δ
...cluster/loadbalance/ConsistentHashLoadBalance.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 51.06% <0%> (-0.36%) 43% <0%> (ø)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 58.94% <0%> (+1.05%) 18% <0%> (ø) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 50% <0%> (+8.33%) 3% <0%> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 56.81% <0%> (+11.36%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940e355...f3e28ad. Read the comment docs.

@diecui1202
Copy link

LGTM. Thanks.

@diecui1202 diecui1202 merged commit 6ebc183 into apache:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants