fix: fix observationsender error & feat: addTracingObservationHandler #13818
Conversation
| .map(ApplicationConfig::getName) | ||
| .orElse(DEFAULT_APPLICATION_NAME); | ||
| String applicationName = dubboConfigProperties.getApplication().getName(); | ||
| if (StringUtils.isBlank(applicationName)) { |
There was a problem hiding this comment.
If spring.applion.name cannot be queried, can dubbo.applion.name be used
There was a problem hiding this comment.
DubboConfigProperties contains dubbo.application.name, which defaults to reading the name of the dubbo. If it cannot be obtained, read the name of spring. If none of them are available, take the default value of unknown.dubo_service
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #13818 +/- ##
==========================================
- Coverage 38.92% 38.88% -0.04%
==========================================
Files 1895 1897 +2
Lines 79300 79317 +17
Branches 11526 11529 +3
==========================================
- Hits 30865 30846 -19
- Misses 44114 44157 +43
+ Partials 4321 4314 -7 ☔ View full report in Codecov by Sentry. |
|
| @@ -101,6 +101,12 @@ | |||
| <dependency> | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter</artifactId> | |||
| <exclusions> | |||
There was a problem hiding this comment.
I think it's unnecessary because we already excluded the artifact in:
https://github.com/apache/dubbo/blob/3.3/dubbo-demo/dubbo-demo-spring-boot/pom.xml#L50
| @@ -101,6 +101,12 @@ | |||
| <dependency> | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter</artifactId> | |||
| <exclusions> | |||
| @@ -62,15 +62,12 @@ public class OpenTelemetryAutoConfiguration { | |||
| /** | |||
| * Default value for application name if {@code spring.application.name} is not set. | |||
| */ | |||
| private static final String DEFAULT_APPLICATION_NAME = "application"; | |||
| private static final String DEFAULT_APPLICATION_NAME = "unknown_dubbo_service"; | |||
|
|
|||
| private final DubboConfigurationProperties dubboConfigProperties; | |||
There was a problem hiding this comment.
From the comments in DubboConfigurationProperties, it seems that DubboConfigurationProperties is only used to generate JSON metadata.
刚刚发现有个地方改错了，类路径不对，3.3得修下