Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the connection but not the client #13600

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

icodening
Copy link
Contributor

What is the purpose of the change

Close the connection but not the client
optimize #13546

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Jan 4, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bdbfd8) 70.37% compared to head (e22b021) 70.35%.
Report is 1 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13600      +/-   ##
==========================================
- Coverage   70.37%   70.35%   -0.02%     
==========================================
  Files        1606     1606              
  Lines       69997    69999       +2     
  Branches    10098    10098              
==========================================
- Hits        49260    49250      -10     
- Misses      16111    16115       +4     
- Partials     4626     4634       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 2cf54f7 into apache:3.2 Jan 19, 2024
18 checks passed
Will-well pushed a commit to Will-well/dubbo that referenced this pull request Jan 31, 2024
* Close the connection but not the client

* Close the connection but not the client
Comment on lines -134 to +135
ch.closeFuture().addListener(channelFuture -> doClose());
// set null but do not close this client, it will be reconnect in the future
ch.closeFuture().addListener(channelFuture -> channel.set(null));
Copy link

@wilsonwu wilsonwu Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this change with problem, not sure if only set channel status to null will cause problem or not? Maybe need dubbo or netty expert to help to answer.

Because we found some problems that 3.2.11 version work with istio, suggest to evaluate and test this change again.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We downgrade to 3.2.10, till now, all works fine.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the 3.2.10 resolved our problems, no errors for connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants