-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the connection but not the client #13600
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13600 +/- ##
==========================================
- Coverage 70.37% 70.35% -0.02%
==========================================
Files 1606 1606
Lines 69997 69999 +2
Branches 10098 10098
==========================================
- Hits 49260 49250 -10
- Misses 16111 16115 +4
- Partials 4626 4634 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Close the connection but not the client * Close the connection but not the client
ch.closeFuture().addListener(channelFuture -> doClose()); | ||
// set null but do not close this client, it will be reconnect in the future | ||
ch.closeFuture().addListener(channelFuture -> channel.set(null)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this change with problem, not sure if only set channel status to null will cause problem or not? Maybe need dubbo or netty expert to help to answer.
Because we found some problems that 3.2.11 version work with istio, suggest to evaluate and test this change again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We downgrade to 3.2.10, till now, all works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the 3.2.10 resolved our problems, no errors for connection.
What is the purpose of the change
Close the connection but not the client
optimize #13546
Brief changelog
Verifying this change
Checklist