Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self used dubbo-bom #12252

Merged
merged 1 commit into from
May 8, 2023
Merged

Remove self used dubbo-bom #12252

merged 1 commit into from
May 8, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented May 8, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ changed the title Remove dubbo-bom self used Remove self used dubbo-bom May 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #12252 (f241179) into 3.2 (ed6afe1) will decrease coverage by 0.27%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12252      +/-   ##
============================================
- Coverage     69.64%   69.38%   -0.27%     
+ Complexity      339        2     -337     
============================================
  Files          1825     1605     -220     
  Lines         95001    66173   -28828     
  Branches      17251     9700    -7551     
============================================
- Hits          66167    45914   -20253     
+ Misses        23395    15830    -7565     
+ Partials       5439     4429    -1010     

see 3430 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 808bc96 into apache:3.2 May 8, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants