Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration center metrics separate module #12096

Merged
merged 16 commits into from
Apr 19, 2023

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Apr 14, 2023

What is the purpose of the change

Detach from default package, use public event api

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to modify a few small areas

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #12096 (82ac68d) into 3.2 (742e035) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12096      +/-   ##
============================================
- Coverage     69.80%   69.56%   -0.24%     
+ Complexity      340        2     -338     
============================================
  Files          3399     1592    -1807     
  Lines        159278    65390   -93888     
  Branches      26524     9520   -17004     
============================================
- Hits         111185    45490   -65695     
+ Misses        38390    15526   -22864     
+ Partials       9703     4374    -5329     

see 1843 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

42.1% 42.1% Coverage
0.0% 0.0% Duplication

@songxiaosheng songxiaosheng merged commit d6f9d8d into apache:3.2 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants