Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.x #778

Closed
wants to merge 2 commits into from
Closed

2.7.x #778

wants to merge 2 commits into from

Conversation

titi1231
Copy link

@titi1231 titi1231 commented Feb 2, 2021

support scan packages using yml list
related to issue #770

@titi1231
Copy link
Author

titi1231 commented Feb 3, 2021

I've checked the log of the failure. The error seems caused by being unable to connect to the zookeeper registry address "zookeeper://192.168.99.100:32770"

import static org.apache.dubbo.spring.boot.util.DubboUtils.DUBBO_PREFIX;
import static org.apache.dubbo.spring.boot.util.DubboUtils.DUBBO_SCAN_PREFIX;
import static org.apache.dubbo.spring.boot.util.DubboUtils.RELAXED_DUBBO_CONFIG_BINDER_BEAN_NAME;
import static org.apache.dubbo.spring.boot.util.DubboUtils.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@titi1231 pls install codestyle check rule to your IDE

wildcard import is not allowed in Dubbo Repo

@codecov-io
Copy link

Codecov Report

Merging #778 (dd3e7af) into 2.7.x (525f26c) will decrease coverage by 3.81%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.7.x     #778      +/-   ##
============================================
- Coverage     61.28%   57.46%   -3.82%     
+ Complexity      158      153       -5     
============================================
  Files            38       38              
  Lines           638      656      +18     
  Branches         60       68       +8     
============================================
- Hits            391      377      -14     
- Misses          223      254      +31     
- Partials         24       25       +1     
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dubbo/spring/boot/util/DubboUtils.java 81.81% <ø> (ø) 4.00 <0.00> (ø)
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 57.89% <20.00%> (-42.11%) 4.00 <0.00> (ø)
...onfigure/DubboRelaxedBindingAutoConfiguration.java 42.85% <20.00%> (-57.15%) 5.00 <0.00> (+1.00) ⬇️
...ntext/event/AwaitingNonWebApplicationListener.java 53.03% <0.00%> (-24.25%) 19.00% <0.00%> (-6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525f26c...f44305a. Read the comment docs.

@titi1231 titi1231 closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants