Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtural_service/destination_rule to dubbo kubernetes #318

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

YarBor
Copy link

@YarBor YarBor commented Aug 20, 2024

What is the purpose of the change

To support future scenario-based configuration to xds mode.

Brief changelog

  • Add {virtural_service/destination_rule}.{proto/crds} to dubbo kubernetes,
  • format import.
  • remove this in generate templete file, it make some bugs in generate vs/ds proto.
{{with $in := .}}
{{range .Selector}}
func (t *{{$in.ResourceName}}) {{.}}() []*{{$pkg}}.Selector {
	return t.Spec.Get{{.}}()
}
{{end}}
{{end}}
  • add envoy.cluster.info() call to get cluster match/config info.
  • add config set operatoration, mesh-config to xds-protocal in pkg/xds/envoy/virtualhosts/routes_configurer.go
  • rename api/mesh/tag.proto.stringMatch to api/mesh/tag.proto.stringMatch_Dubbo, because of name conflict with vs.stringMatch .

Verifying this change

CheckList

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

YarBor added 13 commits August 12, 2024 21:50
resources generate, add vhs config set

Signed-off-by: YarBor <[email protected]>
Signed-off-by: YarBor <[email protected]>
…irtual-service.proto/StringMatch

Signed-off-by: YarBor <[email protected]>
…ICE_TO_DUBBO_KUBERNETES

# Conflicts:
#	api/mesh/v1alpha1/tag_route.proto
…enerate, build api to xds call chain

Signed-off-by: YarBor <[email protected]>
Signed-off-by: YarBor <[email protected]>
@YarBor YarBor force-pushed the ADD_VIRTURAL_SERVICE_TO_DUBBO_KUBERNETES branch from 28d9b9d to 4c7c58e Compare September 2, 2024 11:44
YarBor added 2 commits September 2, 2024 19:46
@YarBor YarBor force-pushed the ADD_VIRTURAL_SERVICE_TO_DUBBO_KUBERNETES branch from e5cbf5d to 8daae3a Compare September 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant