Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front：Optimizing style codes and adding necessary code for instance detail pages #277

Merged
merged 7 commits into from
May 16, 2024
Merged

front：Optimizing style codes and adding necessary code for instance detail pages #277

merged 7 commits into from
May 16, 2024

Conversation

ikun-Lg
Copy link
Contributor

@ikun-Lg ikun-Lg commented May 8, 2024

task：

  1. Extract common duplicate code and improve global style management
  2. Simulate requests using mock and render data to the instance details page
  3. add header component for tab
image

Helltab
Helltab approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Helltab Helltab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ikun-Lg ikun-Lg requested a review from jianyi-gronk May 9, 2024 09:16
jianyi-gronk
jianyi-gronk approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@jianyi-gronk jianyi-gronk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mfordjody mfordjody added console/frontend Console frontend type lgtm This Pull Request is ready for merging. labels May 9, 2024
@chickenlj chickenlj merged commit 80b0053 into apache:master May 16, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianyi-gronk jianyi-gronk jianyi-gronk approved these changes

@Helltab Helltab Helltab approved these changes

Assignees
No one assigned
Labels
console/frontend Console frontend type lgtm This Pull Request is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ikun-Lg @Helltab @jianyi-gronk @chickenlj @mfordjody