Config center feature implement for setting the zookeeper as config center to refresh consumerConfig & providerConfig when dubbogo starting. #99

hxmhlt · 2019-06-21T20:38:12Z

What this PR does:

New feature implement for config center, config refresh from config center when dubbogo start.
Now just have a zookeeper implement for config center.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
You can do a example in examples/dubbo/with-configcenter-go-server/

Does this PR introduce a user-facing change?:

…fig center when dubbogo start

wongoo · 2019-06-22T02:08:14Z

how about make a conference to introduce it to reviewers when there is a big change like this?

hxmhlt · 2019-06-22T03:07:21Z

1.Code in config folder have refactored for supporting config_center to refresh the consumerConfig or providerConfig when dubbogo starting. The core code is in base_config.go.
2.Interface in config_center defined and I implement zookeeper as config_center ,also make it compatible with java 2.7.2.
3.TODO: Dynamic config by using Listeners's in dynamicConfigCenter. Maybe next pr.

hxmhlt · 2019-06-22T03:08:14Z

how about make a conference to introduce it to reviewers when there is a big change like this?

I write the main work in this pr above . May can help you review the code.

codecov-io · 2019-06-22T03:20:39Z

Codecov Report

Merging #99 into master will increase coverage by 4.16%.
The diff coverage is 55.67%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   63.11%   67.27%   +4.16%     
==========================================
  Files          54       67      +13     
  Lines        3652     4086     +434     
==========================================
+ Hits         2305     2749     +444     
+ Misses       1120     1052      -68     
- Partials      227      285      +58

Impacted Files	Coverage Δ
config_center/dynamic_configuration.go	`0% <ø> (ø)`
config_center/mock_dynamic_config.go	`0% <0%> (ø)`
common/url.go	`66.47% <100%> (+0.98%)`	⬆️
config/reference_config.go	`91.78% <100%> (+0.23%)`	⬆️
remoting/zookeeper/facade.go	`74.28% <100%> (ø)`
config/service_config.go	`68.49% <100%> (+0.88%)`	⬆️
config/protocol_config.go	`100% <100%> (ø)`
registry/directory/directory.go	`78.3% <100%> (ø)`	⬆️
remoting/zookeeper/client.go	`59.53% <25%> (+33.66%)`	⬆️
remoting/zookeeper/listener.go	`43.78% <37.77%> (+43.78%)`	⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d8715...d9a170d. Read the comment docs.

common/config/environment.go

common/constant/default.go

common/extension/config_center_factory.go

config/base_config.go

config_center/dynamic_configuration_factory.go

config_center/mock_dynamic_config.go

protocol/jsonrpc/http.go

remoting/listener.go

config_center/zookeeper/impl.go

…t-type

config/protocol_config.go

config/method_config.go

config/provider_config.go

config_center/configuration_parser.go

config_center/zookeeper/impl.go

config_center/zookeeper/impl_test.go

AlexStocks · 2019-06-25T05:50:29Z

examples/dubbo/go-client/app/client.go

-	if conLen == 0 {
-		panic("conMap is nil")
-	}
+	config.Load()


why delete check condition?

config.Load方法已经改为无返回值。之前是返回加载成功的配置数，与yincheng讨论后觉得没有必要，且不优雅。

AlexStocks · 2019-06-25T05:51:41Z

examples/dubbo/go-server/profiles/release/server.yml

-  - id: "hangzhouzk"
-    type: "zookeeper"
+  "hangzhouzk":
+    protocol: "zookeeper"


type -> protocol? Is zookeeper a protocol?

是的，这里与java的叫法保持一致了。

AlexStocks · 2019-06-25T05:54:49Z

remoting/zookeeper/facade.go

@@ -30,7 +30,7 @@ import (
 	"github.com/apache/dubbo-go/common/logger"
 )

-type ZkClientContainer interface {
+type zkClientFacade interface {


which change its name?

container叫法感觉别扭，感觉这种实现方式，类似于设计模式之门面模式。

gaoxinge · 2019-06-27T23:09:44Z

common/config/environment.go

+	return instance
+}
+
+//func (env *Environment) SetConfigCenterFirst() {


Why not remove comment?

gaoxinge · 2019-06-27T23:09:59Z

common/config/environment.go

+//	env.configCenterFirst = true
+//}
+
+//func (env *Environment) ConfigCenterFirst() bool {


这里我估计后面添加新的配置级别，就会要加上，所以没有直接去掉，先注释掉了。先不删吧

config_center/zookeeper/impl_test.go

config/provider_config.go

common/url.go

gaoxinge · 2019-06-27T23:20:23Z

I have added some review comments on codes. I also want to ask when this pr will be merged into master?

AlexStocks · 2019-06-29T07:35:47Z

I have added some review comments on codes. I also want to ask when this pr will be merged into master?

I do not know. So big pr.

hxmhlt added 4 commits June 12, 2019 20:24

Ftr:config_center

bbc3482

Ftr:config center for start

0c2b5a6

Ftr: new feature implement for config center, config refresh from con…

48ee481

…fig center when dubbogo start

Mod: resolve conflict

22771a2

Mod:resolve conflict

54f4299

Fix:for support go 1.11 so change strings.ReplaceAll to strings.Replace

bfd1a4d

Add:unit test in url

618a37b

AlexStocks reviewed Jun 22, 2019

View reviewed changes

Mod: based on AlexStock's review

3ae34d4

fangyincheng reviewed Jun 22, 2019

View reviewed changes

config_center/zookeeper/impl.go Outdated Show resolved Hide resolved

hxmhlt added 3 commits June 22, 2019 23:01

Mod:fmt & rollback protocol/jsonrpc/http.go changed

5136273

Mod:fmt

94785b6

Add: unit_test for remoting zk & Mod: content-protocol back to conten…

a808825

…t-type

AlexStocks reviewed Jun 25, 2019

View reviewed changes

hxmhlt added 2 commits June 25, 2019 21:13

Mod:change some syntax

8ccc931

Add:comment for example yml

ef4e4af

gaoxinge reviewed Jun 27, 2019

View reviewed changes

Mod:format code

356aafe

gaoxinge approved these changes Jun 29, 2019

View reviewed changes

hxmhlt added 2 commits June 30, 2019 00:36

Merge remote-tracking branch 'apache/master' into config_center

0296b01

Mod:merge master code

d9a170d

AlexStocks merged commit 1aa5bcb into apache:master Jun 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Config center feature implement for setting the zookeeper as config center to refresh consumerConfig & providerConfig when dubbogo starting. #99

Config center feature implement for setting the zookeeper as config center to refresh consumerConfig & providerConfig when dubbogo starting. #99

hxmhlt commented Jun 21, 2019

wongoo commented Jun 22, 2019 •

edited

Loading

hxmhlt commented Jun 22, 2019

hxmhlt commented Jun 22, 2019 •

edited

Loading

codecov-io commented Jun 22, 2019 •

edited

Loading

AlexStocks Jun 25, 2019

hxmhlt Jun 25, 2019

AlexStocks Jun 25, 2019

hxmhlt Jun 25, 2019

hxmhlt Jun 25, 2019

AlexStocks Jun 25, 2019

hxmhlt Jun 25, 2019

gaoxinge Jun 27, 2019

gaoxinge Jun 27, 2019

hxmhlt Jun 29, 2019

gaoxinge commented Jun 27, 2019

AlexStocks commented Jun 29, 2019

Config center feature implement for setting the zookeeper as config center to refresh consumerConfig & providerConfig when dubbogo starting. #99

Config center feature implement for setting the zookeeper as config center to refresh consumerConfig & providerConfig when dubbogo starting. #99

Conversation

hxmhlt commented Jun 21, 2019

wongoo commented Jun 22, 2019 • edited Loading

hxmhlt commented Jun 22, 2019

hxmhlt commented Jun 22, 2019 • edited Loading

codecov-io commented Jun 22, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaoxinge commented Jun 27, 2019

AlexStocks commented Jun 29, 2019

wongoo commented Jun 22, 2019 •

edited

Loading

hxmhlt commented Jun 22, 2019 •

edited

Loading

codecov-io commented Jun 22, 2019 •

edited

Loading