Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ftr] lint codes fix. #941

Merged
merged 3 commits into from
Dec 27, 2020
Merged

[Ftr] lint codes fix. #941

merged 3 commits into from
Dec 27, 2020

Conversation

cityiron
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #933

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx added the improve Refactor or improve label Dec 20, 2020
@zouyx zouyx added this to the v1.5.6 milestone Dec 20, 2020
@AlexStocks AlexStocks force-pushed the fix-lint branch 3 times, most recently from 8e26239 to 6379559 Compare December 26, 2020 15:12
@codecov-io
Copy link

codecov-io commented Dec 26, 2020

Codecov Report

Merging #941 (3dc72d2) into develop (e2954fe) will decrease coverage by 0.07%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #941      +/-   ##
===========================================
- Coverage    59.92%   59.85%   -0.08%     
===========================================
  Files          260      261       +1     
  Lines        12840    12909      +69     
===========================================
+ Hits          7695     7727      +32     
- Misses        4186     4229      +43     
+ Partials       959      953       -6     
Impacted Files Coverage Δ
cluster/router/condition/router.go 78.91% <0.00%> (ø)
common/proxy/proxy.go 90.19% <ø> (+0.87%) ⬆️
common/proxy/proxy_factory/default.go 13.33% <0.00%> (-0.23%) ⬇️
common/rpc_service.go 88.11% <ø> (ø)
config_center/file/impl.go 52.47% <ø> (ø)
...lter_impl/tps/tps_limit_sliding_window_strategy.go 100.00% <ø> (ø)
metadata/service/remote/service.go 39.72% <0.00%> (ø)
registry/consul/registry.go 49.33% <0.00%> (ø)
registry/zookeeper/registry.go 48.17% <0.00%> (-2.19%) ⬇️
remoting/getty/getty_client.go 41.97% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2954fe...3dc72d2. Read the comment docs.

@AlexStocks AlexStocks merged commit 970568c into apache:develop Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants