Remove unmeaning logic #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zouyx
reviewed
Nov 9, 2020
registry/zookeeper/registry.go
Outdated
| @@ -290,20 +290,17 @@ func (r *zkRegistry) getCloseListener(conf *common.URL) (*RegistryConfigurationL | |||
|
|
|||
| var zkListener *RegistryConfigurationListener | |||
| r.dataListener.mutex.Lock() | |||
| defer r.dataListener.mutex.Unlock() | |||
There was a problem hiding this comment.
If this lock use defer, will include listenerLock, is it right logic?
There was a problem hiding this comment.
No.....getListener use defer too, so here may be cause dead lock.
|
wait for @CodingSinger's comment |
看了下之前的pr，这里应该是忘了写了，应该在close以及替换的时候设置close为true |
wenxuwan
force-pushed
the
fix_some_bad_logic
branch
from
2346339
to
1942615
Compare
done |
Codecov Report
@@ Coverage Diff @@
## develop #855 +/- ##
===========================================
+ Coverage 59.91% 60.03% +0.12%
===========================================
Files 260 260
Lines 12807 12810 +3
===========================================
+ Hits 7673 7691 +18
+ Misses 4177 4162 -15
Partials 957 957
Continue to review full report at Codecov.
|
fangyincheng
approved these changes
Nov 21, 2020
AlexStocks
approved these changes
Dec 1, 2020
zouyx
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Remove the unmeaning variables in RegistryDataListener and change unlock to defer.