Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod: Remove unnecessary return and judgement. #730

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Mod: Remove unnecessary return and judgement. #730

merged 1 commit into from
Aug 31, 2020

Conversation

atlas-comstock
Copy link
Contributor

@atlas-comstock atlas-comstock commented Aug 27, 2020 •
edited
Loading

What this PR does: Sharp the code.

Which issue(s) this PR fixes: Readable code.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

AlexStocks
AlexStocks reviewed Aug 27, 2020
View reviewed changes
common/rpc_service.go Outdated Show resolved Hide resolved
config/base_config.go Outdated Show resolved Hide resolved
config/reference_config.go Outdated Show resolved Hide resolved
registry/protocol/protocol.go Outdated Show resolved Hide resolved
remoting/zookeeper/curator_discovery/service_discovery.go Outdated Show resolved Hide resolved
zouyx
zouyx reviewed Aug 28, 2020
View reviewed changes
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more improve as below

@atlas-comstock atlas-comstock changed the title chore: Remove unnecessary return and judgement. Mod: Remove unnecessary return and judgement. Aug 28, 2020
@atlas-comstock atlas-comstock changed the base branch from master to develop August 28, 2020 02:42
@atlas-comstock
Copy link
Contributor Author

@zouyx hi, about the travis error, it is strange that my commit base on develop branch will pass( it was based on master branch before). Is it the reason why it reported error?

@zouyx
Copy link
Member

zouyx commented Aug 29, 2020

@zouyx hi, about the travis error, it is strange that my commit base on develop branch will pass( it was based on master branch before). Is it the reason why it reported error?

Maybe.........

zouyx
zouyx reviewed Aug 29, 2020
View reviewed changes
config/base_config.go Outdated Show resolved Hide resolved
config/reference_config.go Outdated Show resolved Hide resolved
filter/filter_impl/access_log_filter.go Outdated Show resolved Hide resolved
protocol/rest/rest_exporter.go Outdated Show resolved Hide resolved
remoting/zookeeper/curator_discovery/service_discovery.go Outdated Show resolved Hide resolved
registry/protocol/protocol.go Outdated Show resolved Hide resolved
@zouyx zouyx added this to the 1.5.2 milestone Aug 30, 2020
@zouyx zouyx added enhancement New feature or request improve Refactor or improve and removed enhancement New feature or request labels Aug 30, 2020
@AlexStocks AlexStocks merged commit 4c483e0 into apache:develop Aug 31, 2020
zouyx added a commit to zouyx/dubbo-go that referenced this pull request Sep 22, 2020
@zouyx
Merge pull request apache#730 from YongHaoWu/remove-unnecessary-state…
a16259d 
…ment

Mod: Remove unnecessary return and judgement.
# Conflicts:
#	cluster/router/tag/tag_router.go
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
@zouyx
Merge pull request #730 from YongHaoWu/remove-unnecessary-statement
177eaf3 
Mod: Remove unnecessary return and judgement.
# Conflicts:
#	cluster/router/tag/tag_router.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoxinge gaoxinge gaoxinge approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@zouyx zouyx zouyx approved these changes

Assignees
No one assigned
Labels
improve Refactor or improve
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@atlas-comstock @zouyx @AlexStocks @gaoxinge