Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftr: add TLS support #685

Merged
merged 25 commits into from
Aug 14, 2020
Merged

Ftr: add TLS support #685

merged 25 commits into from
Aug 14, 2020

Conversation

aliiohs
Copy link
Member

@aliiohs aliiohs commented Aug 2, 2020

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@aliiohs aliiohs changed the base branch from master to develop August 2, 2020 11:59
@zouyx zouyx added this to the 1.5.1 milestone Aug 2, 2020
@zouyx zouyx linked an issue Aug 2, 2020 that may be closed by this pull request
Align with Dubbo: TLS support #598
Closed
AlexStocks
AlexStocks reviewed Aug 5, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@aliiohs aliiohs mentioned this pull request Aug 6, 2020
Merged
zouyx
zouyx approved these changes Aug 7, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@zouyx
Copy link
Member

zouyx commented Aug 7, 2020

Fix travis failing

zouyx
zouyx reviewed Aug 9, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@zouyx zouyx self-assigned this Aug 9, 2020
@zouyx zouyx added the enhancement New feature or request label Aug 9, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2020 •
edited
Loading

Codecov Report

Merging #685 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #685   +/-   ##
========================================
  Coverage    64.11%   64.11%           
========================================
  Files          238      238           
  Lines        12544    12544           
========================================
  Hits          8042     8042           
  Misses        3727     3727           
  Partials       775      775

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0017a8...cb30a98. Read the comment docs.

zouyx
zouyx reviewed Aug 9, 2020
View reviewed changes
protocol/dubbo/config.go Outdated Show resolved Hide resolved
zouyx
zouyx reviewed Aug 11, 2020
View reviewed changes
protocol/dubbo/config.go Outdated Show resolved Hide resolved
config/config_loader.go Show resolved Hide resolved
protocol/dubbo/pool.go Outdated Show resolved Hide resolved
protocol/dubbo/pool.go Outdated Show resolved Hide resolved
@hxmhlt hxmhlt changed the title Add tsl support Add tls support Aug 11, 2020
@zouyx zouyx changed the title Add tls support Ftr: add tls support Aug 11, 2020
@zouyx zouyx changed the title Ftr: add tls support Ftr: add TLS support Aug 11, 2020
gaoxinge
gaoxinge reviewed Aug 13, 2020
View reviewed changes
protocol/dubbo/server.go Outdated Show resolved Hide resolved
gaoxinge
gaoxinge reviewed Aug 13, 2020
View reviewed changes
protocol/dubbo/config.go Outdated Show resolved Hide resolved
config/consumer_config.go Outdated Show resolved Hide resolved
@zouyx zouyx merged commit aa0ee1c into apache:develop Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@zouyx zouyx zouyx approved these changes

@gaoxinge gaoxinge gaoxinge approved these changes

@hxmhlt hxmhlt hxmhlt approved these changes

Assignees

@zouyx zouyx

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

Align with Dubbo: TLS support
6 participants
@aliiohs @zouyx @codecov-commenter @AlexStocks @hxmhlt @gaoxinge