-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Nearest first for multiple registry #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done bro.
But i think this is a new featrue for dubbo-go
, so should change the title base on https://github.com/apache/dubbo-go/blob/master/contributing.md
If not ready for merge , should change the status to draft
as below
OK,I will do better next. |
I think it should be a new feature. But the original extension |
Have u finished you pr? Plc merge the latest develop branch to fix the conflict problembs. |
pull request develop branch
This feature base on java implementation,no registryAware but zoneAware only. |
Finish and merge develop branch. |
merge develop
# Conflicts: # common/constant/key.go # config/registry_config.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #659 +/- ##
===========================================
+ Coverage 63.58% 63.93% +0.34%
===========================================
Files 239 238 -1
Lines 12650 12487 -163
===========================================
- Hits 8044 7983 -61
+ Misses 3821 3740 -81
+ Partials 785 764 -21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for travis pass
sample pr: dubbogo/dubbo-samples#6 |
What this PR does:
This extension provides a strategy to decide how to distribute traffics among them:
Which issue(s) this PR fixes:
Fixes #597
Special notes for your reviewer:
@zouyx
Does this PR introduce a user-facing change?: