Fix: zk disconnected, dubbo-go panic when subscribe. #613
Conversation
what's the meaning of Travis failing? As the picture shown, all checks have passed. |
Sorry. File still conflicting |
ok, done |
| //When Zk disconnected, the Conn will be set to nil, so here need check the value of Conn | ||
| l.client.RLock() | ||
| if l.client.Conn == nil { | ||
| break |
There was a problem hiding this comment.
Can this case trigger to auto-reconnect?
There was a problem hiding this comment.
I have the same question. But travis still failing.
There was a problem hiding this comment.
In my opinion, there is already have other case for trigger reconnect, so here may be just need stop the resubscribe process and wait reconnect finished.
By the way, the travis failed should not be caused by my changes, the error is:
may be you can re-trigger it..
| //When Zk disconnected, the Conn will be set to nil, so here need check the value of Conn | ||
| l.client.RLock() | ||
| if l.client.Conn == nil { | ||
| break |
There was a problem hiding this comment.
Based on https://github.com/apache/dubbo-go/blob/master/contributing.md to change the title
zouyx
changed the title
What this PR does:
Which issue(s) this PR fixes:
try to fix #610
-->
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: