Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: add comments for remoting #605

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

watermelo
Copy link
Member

What this PR does:
add comments for remoting

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2020

Codecov Report

Merging #605 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #605      +/-   ##
===========================================
+ Coverage    67.21%   67.37%   +0.16%     
===========================================
  Files          188      190       +2     
  Lines         9852     9917      +65     
===========================================
+ Hits          6622     6682      +60     
  Misses        2580     2580              
- Partials       650      655       +5     
Impacted Files Coverage Δ
registry/etcdv3/registry.go 73.13% <ø> (ø)
remoting/etcdv3/client.go 57.80% <ø> (ø)
remoting/etcdv3/facade.go 0.00% <ø> (ø)
remoting/etcdv3/listener.go 46.49% <ø> (+0.40%) ⬆️
remoting/kubernetes/client.go 76.25% <ø> (ø)
remoting/kubernetes/listener.go 52.83% <ø> (ø)
remoting/kubernetes/registry_controller.go 55.67% <ø> (ø)
remoting/kubernetes/watch.go 78.89% <ø> (ø)
remoting/zookeeper/client.go 68.68% <ø> (ø)
remoting/zookeeper/facade.go 70.27% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ae61d...7537535. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zouyx zouyx linked an issue Jun 15, 2020 that may be closed by this pull request
@flycash flycash merged commit 1f66772 into apache:develop Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Add comments for remoting directory
5 participants