Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: add comment for metadata #588

Merged
merged 9 commits into from
Jun 10, 2020

Conversation

watermelo
Copy link
Member

What this PR does:
add comment for metadata

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #588 into develop will increase coverage by 1.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #588      +/-   ##
===========================================
+ Coverage    66.43%   67.53%   +1.10%     
===========================================
  Files          184      188       +4     
  Lines         9712     9852     +140     
===========================================
+ Hits          6452     6654     +202     
+ Misses        2620     2546      -74     
- Partials       640      652      +12     
Impacted Files Coverage Δ
cluster/directory/base_directory.go 56.81% <0.00%> (-9.10%) ⬇️
registry/kubernetes/registry.go 67.30% <0.00%> (-3.85%) ⬇️
remoting/kubernetes/listener.go 52.83% <0.00%> (-3.25%) ⬇️
cluster/cluster_impl/base_cluster_invoker.go 70.83% <0.00%> (-1.64%) ⬇️
cluster/cluster_impl/failover_cluster_invoker.go 71.15% <0.00%> (-1.19%) ⬇️
cluster/cluster_impl/forking_cluster_invoker.go 58.33% <0.00%> (-0.21%) ⬇️
config/base_config.go 64.14% <0.00%> (ø)
config/graceful_shutdown.go 58.62% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <0.00%> (ø)
config/config_center_config.go 71.42% <0.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af26b9...92a019d. Read the comment docs.

@watermelo
Copy link
Member Author

#570

@zouyx zouyx linked an issue Jun 6, 2020 that may be closed by this pull request
@zouyx zouyx changed the title Ftr: add comment for metadata Mod: add comment for metadata Jun 7, 2020
@AlexStocks AlexStocks merged commit 75ae61d into apache:develop Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Add comments for metadata directory
5 participants