-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod: add comment for metadata #588
Merged
AlexStocks
merged 9 commits into
apache:develop
from
watermelo:featue/addCommentForMetadata
Jun 10, 2020
Merged
Mod: add comment for metadata #588
AlexStocks
merged 9 commits into
apache:develop
from
watermelo:featue/addCommentForMetadata
Jun 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watermelo
commented
Jun 6, 2020
Codecov Report
@@ Coverage Diff @@
## develop #588 +/- ##
===========================================
+ Coverage 66.43% 67.53% +1.10%
===========================================
Files 184 188 +4
Lines 9712 9852 +140
===========================================
+ Hits 6452 6654 +202
+ Misses 2620 2546 -74
- Partials 640 652 +12
Continue to review full report at Codecov.
|
zouyx
reviewed
Jun 8, 2020
AlexStocks
approved these changes
Jun 8, 2020
flycash
approved these changes
Jun 9, 2020
AlexStocks
reviewed
Jun 9, 2020
zouyx
approved these changes
Jun 9, 2020
AlexStocks
reviewed
Jun 9, 2020
…ermelo/dubbo-go into featue/addCommentForMetadata
…ermelo/dubbo-go into featue/addCommentForMetadata
…ermelo/dubbo-go into featue/addCommentForMetadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
add comment for metadata
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: