-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod: update the comments in filter directory #586
Merged
zouyx
merged 4 commits into
apache:develop
from
williamfeng323:feature/filter-comment-optimise
Jun 6, 2020
Merged
Mod: update the comments in filter directory #586
zouyx
merged 4 commits into
apache:develop
from
williamfeng323:feature/filter-comment-optimise
Jun 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamfeng323
changed the title
Feature/filter comment optimise
Mod: update the comments in filter directory
Jun 4, 2020
williamfeng323
force-pushed
the
feature/filter-comment-optimise
branch
from
June 4, 2020 16:17
106706c
to
b0c34c2
Compare
AlexStocks
requested review from
CodingSinger and
flycash
and removed request for
CodingSinger
June 4, 2020 16:21
AlexStocks
approved these changes
Jun 4, 2020
Codecov Report
@@ Coverage Diff @@
## develop #586 +/- ##
===========================================
+ Coverage 66.43% 66.68% +0.25%
===========================================
Files 184 185 +1
Lines 9712 9749 +37
===========================================
+ Hits 6452 6501 +49
+ Misses 2620 2611 -9
+ Partials 640 637 -3
Continue to review full report at Codecov.
|
flycash
approved these changes
Jun 5, 2020
zouyx
reviewed
Jun 5, 2020
zouyx
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added comments to filter directory
Which issue(s) this PR fixes:
Fixes #569