Nacos MetadataReport implementation #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flycash
changed the title
Codecov Report
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #522 +/- ##
=======================================================
+ Coverage 66.06% 66.16% +0.10%
=======================================================
Files 203 204 +1
Lines 10558 10610 +52
=======================================================
+ Hits 6975 7020 +45
- Misses 2909 2912 +3
- Partials 674 678 +4
Continue to review full report at Codecov.
|
flycash
changed the title
zouyx
reviewed
May 29, 2020
AlexStocks
reviewed
May 31, 2020
AlexStocks
approved these changes
Jun 3, 2020
fangyincheng
reviewed
Jun 3, 2020
| ftry := &nacosMetadataReportFactory{} | ||
| extension.SetMetadataReportFactory("nacos", func() factory.MetadataReportFactory { | ||
| return ftry | ||
| }) |
There was a problem hiding this comment.
It is recommended to provide a method named Newxxx？
There was a problem hiding this comment.
If we provide NewXXX method, the factory should be singleton and we need factoryInstance + factoryInitOnce, but using closure can simply the codes
zouyx
reviewed
Jun 3, 2020
metadata/report/nacos/report.go
Outdated
Comment on lines
175
to
177
| if err != nil { | ||
| logger.Errorf("The config is invalid: %s", cfg) | ||
| } |
There was a problem hiding this comment.
If error is not null .....then not return? Is it right logic?
And this method has not testcase to cover it .
zouyx
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement MetadataReport based on Nacos
Fixes #446