Imp: refactor the network transport layer #495

cvictory · 2020-04-26T12:17:05Z

现在dubbo和getty耦合度很高，所以先进行第一轮抽象，部分逻辑后续待优化。
做的改动：

增加exchange层做中转，连接dubbo协议和网络交互。exchange入参出参是invocation和result，网络层入参出参是request和response
在dubbo_protocol中增加共用相同连接（客户端访问server，当ip和端口相同，就共用exchange）
将getty相关的逻辑移到remoting/getty下，将addr和requestTimeout删除，getty服务管理连接，每个请求的超时，都是请求的入口传入，方便前面提到的连接共享
抽象codec接口
5.requestId变成全局，PendingResponse也变成全局

待优化的小的功能点：

codec和remoting.client下后续可以抽象成扩展。现在还是编码形式存在。
codec中的hessian编解码，期望能对hessian进行抽象
getty中的逻辑尽量保持了和原来的逻辑一直，没有做调整，后续看下getty和remoting/getty之间的api层是否可以抽象。

代码主干流程完成，部分异常和分支流程待完善，单元测试待完善。先提交给大家看下

flycash · 2020-04-26T14:30:40Z

@Patrick0308 有时间看看

Patrick0308 · 2020-04-27T06:21:10Z

@flycash OK

pantianying

Can the current program run through the closed-loop state？

pantianying · 2020-04-27T14:46:03Z

remoting/exchange_client.go

+	return exchangeClient
+}
+
+func (client *ExchangeClient) Request(invocation *protocol.Invocation, url common.URL, timeout time.Duration,


超时时间等需要每次请求再计算下因为有method维度的配置

参考：protocol/dubbo/dubbo_invoker.go:137

pantianying · 2020-04-27T14:47:33Z

remoting/exchange_client.go

+		client:         client,
+	}
+	client.SetExchangeClient(exchangeClient)
+	client.Connect(url)


client.Connect需要返回是否成功吧

如果连接不上，这个ip不能创建invoker。
以增加测试用例。

pantianying · 2020-04-27T14:48:59Z

remoting/exchange_server.go

+}
+
+func (server *ExchangeServer) Start() {
+	(server.Server).Start()


是否必要加(server.Server)中的（）

已删除，原来定义成指针，现在不需要了。

Patrick0308

Please remove useless file and code making easier to review.

AlexStocks · 2020-05-04T03:39:35Z

@cvictory If u completed ur work and need review, pls give us ur request for review.

codecov-io · 2020-05-08T09:53:53Z

Codecov Report

Merging #495 into feature/dubbo-protocol-restructure will decrease coverage by 0.94%.
The diff coverage is 62.16%.

@@                          Coverage Diff                           @@
##           feature/dubbo-protocol-restructure     #495      +/-   ##
======================================================================
- Coverage                               67.20%   66.25%   -0.95%     
======================================================================
  Files                                     174      174              
  Lines                                    9261     9330      +69     
======================================================================
- Hits                                     6224     6182      -42     
- Misses                                   2432     2530      +98     
- Partials                                  605      618      +13

Impacted Files	Coverage Δ
config/application_config.go	`41.66% <ø> (ø)`
remoting/getty/config.go	`13.15% <ø> (ø)`
remoting/getty/listener.go	`40.76% <37.93%> (ø)`
remoting/getty/getty_client.go	`51.45% <51.45%> (ø)`
protocol/dubbo/dubbo_protocol.go	`74.72% <60.37%> (-17.12%)`	⬇️
protocol/dubbo/dubbo_invoker.go	`77.63% <70.00%> (-4.63%)`	⬇️
protocol/dubbo/dubbo_codec.go	`70.27% <70.27%> (ø)`
remoting/getty/readwriter.go	`60.00% <85.71%> (ø)`
remoting/getty/getty_server.go	`63.52% <92.30%> (ø)`
protocol/jsonrpc/jsonrpc_invoker.go	`100.00% <100.00%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3c02c...adb55ce. Read the comment docs.

cvictory · 2020-05-09T06:25:05Z

@cvictory If u completed ur work and need review, pls give us ur request for review.

please review it again.

cvictory · 2020-05-11T08:45:15Z

@Patrick0308 @pantianying pls review this pr.

AlexStocks · 2020-05-12T05:13:21Z

protocol/dubbo/dubbo_codec.go

+	remoting.NewCodec("dubbo", codec)
+}
+
+// DubboPackage ...


pls add comment for the public structs/funcs

AlexStocks · 2020-05-12T05:14:21Z

protocol/dubbo/dubbo_codec.go

+	return fmt.Sprintf("DubboPackage: Header-%v, Path-%v, Body-%v", p.Header, p.Service, p.Body)
+}
+
+// Marshal ...


Add comment.

AlexStocks · 2020-05-12T05:14:29Z

protocol/dubbo/dubbo_codec.go

+	return bytes.NewBuffer(pkg), nil
+}
+
+// Unmarshal ...


add comment

protocol/dubbo/dubbo_codec.go

AlexStocks · 2020-05-12T05:46:37Z

remoting/exchange_server.go

+	"github.com/apache/dubbo-go/common"
+)
+
+type Server interface {


add comment for the public structs/funcs.

AlexStocks · 2020-05-12T05:46:57Z

remoting/getty/dubbo_codec_for_test.go

+	"strconv"
+	"time"
+
+	hessian "github.com/apache/dubbo-go-hessian2"


pls using anther import block.

AlexStocks · 2020-05-12T05:47:16Z

remoting/getty/dubbo_codec_for_test.go

+	return bytes.NewBuffer(pkg), nil
+}
+
+// Unmarshal ...


add comment for public strucs/funcs.

it is unit test.

AlexStocks · 2020-05-12T05:48:01Z

remoting/getty/getty_client.go

+	"math/rand"
+	"time"
+
+	"github.com/apache/dubbo-go/remoting"


pls using three import import blocks as other dubbo-go files.

AlexStocks · 2020-05-12T05:48:33Z

remoting/getty/getty_client.go

+	rand.Seed(time.Now().UnixNano())
+}
+
+// SetClientConf ...


pls add comment for public funcs/structs in this file.

protocol/dubbo/dubbo_codec.go

remoting/getty/dubbo_codec_for_test.go

hxmhlt · 2020-05-12T13:07:46Z

pls add some ut. The ut coverage is lower.

pantianying · 2020-05-14T14:35:53Z

remoting/codec.go

+	codec = make(map[string]Codec, 2)
+}
+
+func NewCodec(protocol string, codecTmp Codec) {


maybe It would be better to replace new with register？

pantianying · 2020-05-14T14:37:28Z

remoting/codec.go

+	codec map[string]Codec
+)
+
+func init() {


No need to initialize in init
example：
var codec=make( map[string]Codec)

pantianying · 2020-05-14T14:41:41Z

remoting/exchange_client.go

+	client.SetExchangeClient(exchangeClient)
+	if client.Connect(url) != nil {
+		//retry for a while
+		time.Sleep(1 * time.Second)


If it's necessary to try again, there's no need to wait for a while

连接有可能瞬时的网络问题，所以sleep了100ms

pantianying · 2020-05-14T14:44:46Z

remoting/exchange_client.go

+
+	if pendingResponse.Callback == nil {
+		pendingResponse.Err = pendingResponse.response.Error
+		pendingResponse.Done <- struct{}{}


use close(pendingResponse.Done)

这个和原来是一致的。为什么要直接关闭？

一般chan 作为一次性关闭使用都是close，可以让全部协程<-Done 都触发。只发送一个信号，如果该Done在多个协程使用了，只能关闭一个协程。

这个只有一个地方使用，这个地方就是接受相应请求。后续可以考虑。

pantianying · 2020-05-14T14:47:47Z

remoting/getty/getty_client.go

+	if session == nil {
+		return errSessionNotExist
+	}
+	defer func() {


这样的写法有点奇怪，这里没有必要用defer吧。。

删除了。

fangyincheng · 2020-05-17T17:16:26Z

protocol/invocation/rpcinvocation.go

@@ -141,6 +141,29 @@ func (r *RPCInvocation) SetCallBack(c interface{}) {
 	r.callBack = c
 }

+func (r *RPCInvocation) ServiceKey() string {


why add ServiceKey here？ is url.servicekey wrong?

因为回来的时候，所有参数放到了rpcInvocation中。按照dubbo java做法，其实invocation下会有invoker，再通过invoker获取url。这里暂时不去完全适配。

这个invocation里面不是有invoker吗？

invoker需要去获取，暂时还没有。原来逻辑里是通过构建一个url，通过url.ServiceKey来获取服务标识。

protocol/dubbo/dubbo_protocol_test.go

fangyincheng · 2020-05-17T18:06:00Z

protocol/dubbo/dubbo_protocol.go

-		requestTimeout = t
+	exchangeClient := getExchangeClient(url)
+	if exchangeClient == nil {
+		return nil


when get nil exchangeClient， if we should throw a error?

type Protocol interface { Export(invoker Invoker) Exporter Refer(url common.URL) Invoker Destroy() }

这个接口的Refer接口，没有error返回值，所以要么只能panic，要么只能返回nil.

因为连接不上认为是比较常见的问题，所以返回nil来支持。

java中是往上抛异常。

so add warning log？

加一句日志会更好一点。不过我们后面应该考虑一下要不要修改这个返回值，支持返回error。

我增加一个warning的log吧。

codecov-commenter · 2020-05-19T07:25:42Z

Codecov Report

Merging #495 into feature/dubbo-protocol-restructure will decrease coverage by 1.11%.
The diff coverage is 60.08%.

@@                          Coverage Diff                           @@
##           feature/dubbo-protocol-restructure     #495      +/-   ##
======================================================================
- Coverage                               67.20%   66.09%   -1.12%     
======================================================================
  Files                                     174      174              
  Lines                                    9261     9343      +82     
======================================================================
- Hits                                     6224     6175      -49     
- Misses                                   2432     2544     +112     
- Partials                                  605      624      +19

Impacted Files	Coverage Δ
common/url.go	`71.15% <0.00%> (ø)`
config/application_config.go	`41.66% <ø> (ø)`
protocol/jsonrpc/jsonrpc_invoker.go	`100.00% <ø> (ø)`
...rotocol/protocolwrapper/protocol_filter_wrapper.go	`48.64% <0.00%> (-2.78%)`	⬇️
remoting/getty/config.go	`13.15% <ø> (ø)`
remoting/getty/listener.go	`39.49% <37.93%> (ø)`
remoting/getty/getty_client.go	`44.68% <44.68%> (ø)`
protocol/dubbo/dubbo_protocol.go	`71.69% <58.82%> (-20.14%)`	⬇️
protocol/dubbo/dubbo_invoker.go	`77.63% <70.00%> (-4.63%)`	⬇️
protocol/dubbo/dubbo_codec.go	`70.27% <70.27%> (ø)`
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3c02c...5ba2307. Read the comment docs.

AlexStocks · 2020-05-23T03:13:08Z

config/application_config.go

@@ -40,7 +37,7 @@ func (*ApplicationConfig) Prefix() string {
 	return constant.DUBBO + ".application."
 }

-// Id ...
+// ID ...


if u do not wanna add comment here, pls add // nolint.

ok. It is keep the same as before.

fangyincheng · 2020-05-23T08:50:44Z

config/application_config.go

 import (
 	"github.com/apache/dubbo-go/common/constant"
+	"github.com/creasty/defaults"


fangyincheng · 2020-05-23T09:26:36Z

protocol/dubbo/dubbo_invoker.go

@@ -19,7 +19,10 @@ package dubbo

 import (
 	"context"
+	"github.com/apache/dubbo-go/config"


fangyincheng · 2020-05-23T09:28:13Z

protocol/dubbo/dubbo_invoker.go

@@ -48,21 +51,31 @@ var (
 	attachmentKey = []string{constant.INTERFACE_KEY, constant.GROUP_KEY, constant.TOKEN_KEY, constant.TIMEOUT_KEY}
 )

-// DubboInvoker ...
+// DubboInvoker. It is implement of protocol.Invoker. One dubboInvoker refer to one service and ip.


DubboInvoker is implement of protocol.Invoker, a DubboInvoker refer to one service and ip.

fangyincheng · 2020-05-23T09:55:15Z

protocol/dubbo/dubbo_invoker.go

@@ -83,6 +96,9 @@ func (di *DubboInvoker) Invoke(ctx context.Context, invocation protocol.Invocati
 	defer atomic.AddInt64(&(di.reqNum), -1)

 	inv := invocation.(*invocation_impl.RPCInvocation)
+	// init param
+	inv.SetAttachments(constant.PATH_KEY, di.GetUrl().GetParam(constant.INTERFACE_KEY, ""))
+	inv.SetAttachments(constant.VERSION_KEY, di.GetUrl().GetParam(constant.VERSION_KEY, ""))


add to attachmentKey?

because there params are removed in previous process.

好主意。

fangyincheng · 2020-05-23T10:02:48Z

protocol/dubbo/dubbo_invoker.go

 		}
 	}
 	if result.Err == nil {
 		result.Rest = inv.Reply()
-		result.Attrs = response.atta
+		result.Attrs = result.Attachments()


do you set attachments to result?

我的意思是，result.Attachments() 取出来的就是result.Attrs，你这里取自己给自己赋值？而且没看到result的attrs有被赋值，response.atta 原来的这个内容在哪里呢？

en，取错对象了，应用用rest.

fangyincheng · 2020-05-23T10:37:12Z

protocol/dubbo/dubbo_invoker_test.go

@@ -58,7 +57,9 @@ func TestDubboInvoker_Invoke(t *testing.T) {
 	res := invoker.Invoke(context.Background(), inv)
 	assert.NoError(t, res.Error())
 	assert.Equal(t, User{Id: "1", Name: "username"}, *res.Result().(*User))
-	assert.Equal(t, "test_value", res.Attachments()["test_key"]) // test attachments for request/response
+	//result will not contain attachment
+	// attachment in result it is useless.


Have removed.

pantianying

LGTM

flycash · 2020-05-28T08:29:44Z

protocol/dubbo/dubbo_protocol.go

-		requestTimeout = t
+	exchangeClient := getExchangeClient(url)
+	if exchangeClient == nil {
+		return nil


加一句日志会更好一点。不过我们后面应该考虑一下要不要修改这个返回值，支持返回error。

flycash · 2020-05-28T08:34:23Z

protocol/dubbo/dubbo_protocol.go

+
+func getExchangeClient(url common.URL) *remoting.ExchangeClient {
+	clientTmp, ok := exchangeClientMap.Load(url.Location)
+	if !ok {


这一步实际上存在并发隐患。如果多线程进来，同时发现没有，就会同时进来这里，于是创建多个，而后者覆盖前者Store调用的结果。修改的建议是使用double-check在发现!ok之后加锁再尝试取一次，取不到则创建。

增加了一层锁，可以看下：用了syncMap

flycash · 2020-05-28T08:35:15Z

protocol/dubbo/dubbo_protocol.go

+		return exchangeClientTmp
+	}
+	exchangeClient, ok := clientTmp.(*remoting.ExchangeClient)
+	if !ok {


什么情况下会执行到!ok里面？我有点没看懂……

没有情形，会走到这个里面。默认放进去的都是这个类型。

flycash · 2020-05-28T08:37:12Z

protocol/jsonrpc/jsonrpc_invoker.go

@@ -54,7 +53,7 @@ func (ji *JsonrpcInvoker) Invoke(ctx context.Context, invocation protocol.Invoca
 	url := ji.GetUrl()
 	req := ji.client.NewRequest(url, inv.MethodName(), inv.Arguments())
 	ctxNew := context.WithValue(ctx, constant.DUBBOGO_CTX_KEY, map[string]string{
-		"X-Proxy-Id": "dubbogo",
+		"X-Proxy-ID": "dubbogo",


这里修改之后，是否会出现新版本的jsonrpc客户端调过去老版本的jsonrpc服务端失败的问题？因为老版本的可能只能识别"X-Proxy-Id"。

flycash · 2020-05-28T08:39:03Z

remoting/exchange.go

+}
+
+func SequenceId() uint64 {
+	// increse 2 for every request.


最好把为什么+2而不是+1这个讲清楚。这是一个很tricky的事情=。=

加了注释，client-》 server期望用偶数，server-》client用奇数。这个没有强制，只是为了更加方便区分。

flycash · 2020-05-28T08:40:07Z

remoting/exchange.go

+// NewRequest
+func NewRequest(version string) *Request {
+	return &Request{
+		ID:      int64(SequenceId()),


这里看来，为什么sequenceId不直接生成64位？

之前想用uint表示，后面想了下，还是用int64吧。和java之类的通信，会溢出。

hxmhlt · 2020-06-01T11:38:34Z

protocol/dubbo/dubbo_codec.go

+	p.Service.Method = invocation.MethodName()
+
+	timeout, err := strconv.Atoi(invocation.AttachmentsByKey(constant.TIMEOUT_KEY, "3000"))
+	if err != nil {


You would better define a constant like default timeout for 3000.

hxmhlt · 2020-06-01T11:39:22Z

protocol/dubbo/dubbo_codec.go

+	if err != nil {
+		// it will be wrapped in readwrite.Write .
+		return nil, err
+	}


perrors.WithStack(err)

hxmhlt · 2020-06-01T11:41:55Z

protocol/dubbo/dubbo_codec.go

+		Event:    pkg.Header.Type&hessian.PackageHeartbeat != 0x00,
+	}
+	if pkg.Header.Type&hessian.PackageHeartbeat == 0x00 {
+		// convert params of request


No go fmt? '&' 前后应该有空格才对。建议ide调成自动format

有的，主要是有优先级比较的缘故(& 和 ==)吧。加了个括号就好了。。。

hxmhlt · 2020-06-01T11:45:06Z

protocol/dubbo/dubbo_invoker_test.go

+	argBuf := new(bytes.Buffer)
+	for i := 0; i < 400; i++ {
+		argBuf.WriteString("击鼓其镗，踊跃用兵。土国城漕，我独南行。从孙子仲，平陈与宋。不我以归，忧心有忡。爰居爰处？爰丧其马？于以求之？于林之下。死生契阔，与子成说。执子之手，与子偕老。于嗟阔兮，不我活兮。于嗟洵兮，不我信兮。")
+		argBuf.WriteString("击鼓其镗，踊跃用兵。土国城漕，我独南行。从孙子仲，平陈与宋。不我以归，忧心有忡。爰居爰处？爰丧其马？于以求之？于林之下。死生契阔，与子成说。执子之手，与子偕老。于嗟阔兮，不我活兮。于嗟洵兮，不我信兮。")


I do not think Chinese is ok. Pls mod to English...

这个是之前的用例，我移动了个地方。中文也测试下，可以吧。我加个注释？

hxmhlt · 2020-06-01T11:46:33Z

protocol/dubbo/dubbo_protocol.go

+
+func doHandleRequest(rpcInvocation *invocation.RPCInvocation) protocol.RPCResult {
+	exporter, _ := dubboProtocol.ExporterMap().Load(rpcInvocation.ServiceKey())
+	result := protocol.RPCResult{}


Is dubboProtocol.ExporterMap() may be nil?

除非是非法流量。
处理的逻辑统一在export == nil 里进行处理。

hxmhlt · 2020-06-01T11:50:25Z

remoting/exchange_client.go

+		}
+	}
+	//FIXME atomic operation
+	cl.init = true


need atomic.Bool

hxmhlt · 2020-06-01T11:51:13Z

remoting/exchange_client.go

+		return er
+	}
+	request := NewRequest("2.0.2")
+	request.Data = invocation


2.0.2 means what?

2.0.2 means what?

Pls use constant.

2.0.2是协议版本

这个pr太大了，不做调整了。我去社区提个issue吧，很多地方都有。

fangyincheng

LGTM

hxmhlt

LGTM

cvictory added 2 commits April 24, 2020 11:29

getty refactor

1eb4a83

refactor getty

fa61e9d

flycash requested review from flycash, fangyincheng, AlexStocks and hxmhlt April 26, 2020 14:29

pantianying reviewed Apr 27, 2020

View reviewed changes

Patrick0308 reviewed May 3, 2020

View reviewed changes

cvictory added 2 commits May 8, 2020 17:37

refactor getty

0ba15c8

Merge branch 'master' of github.com:apache/dubbo-go into getty_reactor

9bc37f3

cvictory added 3 commits May 8, 2020 20:02

fix review issue

c67d34a

fix review issue

acc7c79

remove unused code, add license

d48fd1e

cvictory requested a review from pantianying May 9, 2020 06:23

cvictory mentioned this pull request May 9, 2020

provider can get attachment in ctx #508

Merged

AlexStocks reviewed May 12, 2020

View reviewed changes

hxmhlt reviewed May 12, 2020

View reviewed changes

protocol/dubbo/dubbo_codec.go Show resolved Hide resolved

protocol/dubbo/dubbo_codec.go Show resolved Hide resolved

remoting/getty/dubbo_codec_for_test.go Outdated Show resolved Hide resolved

cvictory changed the base branch from master to feature/dubbo-protocol-restructure May 13, 2020 13:21

fix review issue: add comment and some optimization

58e7e86

pantianying reviewed May 14, 2020

View reviewed changes

AlexStocks changed the title ~~重构网络模块~~ Imp: refactor the network transport layer May 15, 2020

fangyincheng reviewed May 17, 2020

View reviewed changes

split import sentense, fix some review

adb55ce

cvictory added 3 commits May 18, 2020 17:20

modify log

1bbe0b4

fix run issue

dc2b68f

fix issue: create gettyClientConn every time

fe3c5b0

cvictory added 2 commits May 19, 2020 20:53

fix : url.getPath contains slash, but it don't in dubbo-java

1e07952

unit test

c6abc0d

AlexStocks reviewed May 23, 2020

View reviewed changes

fangyincheng reviewed May 23, 2020

View reviewed changes

AlexStocks approved these changes May 26, 2020

View reviewed changes

cvictory added 2 commits May 27, 2020 14:38

fix review issue

15608af

remove unused code

cbac0c9

pantianying approved these changes May 28, 2020

View reviewed changes

flycash reviewed May 28, 2020

View reviewed changes

cvictory added 3 commits May 28, 2020 19:06

reactor import

7f9c7a4

fix review issue

7c30fdc

fix review issue

dd36c9c

hxmhlt reviewed Jun 1, 2020

View reviewed changes

cvictory added 3 commits June 2, 2020 11:06

fix review issue

713fcf9

fix review issue

a08d2c7

refactor ServiceKey func

5ba2307

fangyincheng approved these changes Jun 2, 2020

View reviewed changes

hxmhlt approved these changes Jun 4, 2020

View reviewed changes

hxmhlt merged commit a10ff4d into apache:feature/dubbo-protocol-restructure Jun 4, 2020

AlexStocks mentioned this pull request Jun 5, 2020

Why not use the default client #585

Closed

Imp: refactor the network transport layer #495

Imp: refactor the network transport layer #495

Conversation

cvictory commented Apr 26, 2020

flycash commented Apr 26, 2020

Patrick0308 commented Apr 27, 2020

pantianying left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Patrick0308 left a comment

Choose a reason for hiding this comment

AlexStocks commented May 4, 2020

codecov-io commented May 8, 2020 • edited Loading

Codecov Report

cvictory commented May 9, 2020

cvictory commented May 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hxmhlt commented May 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented May 19, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pantianying left a comment

pantianying left a comment •

edited

Loading

codecov-io commented May 8, 2020 •

edited

Loading

codecov-commenter commented May 19, 2020 •

edited

Loading