add zk register code #355
Merged
add zk register code #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.3 #355 +/- ##
=========================================
+ Coverage 66.68% 67.88% +1.2%
=========================================
Files 118 118
Lines 7419 7099 -320
=========================================
- Hits 4947 4819 -128
+ Misses 1981 1809 -172
+ Partials 491 471 -20
Continue to review full report at Codecov.
|
pantianying
requested review from
AlexStocks,
hxmhlt and
fangyincheng
and removed request for
hxmhlt
zouyx
reviewed
Feb 9, 2020
| rawURL string | ||
| encodedURL string | ||
| dubboPath string | ||
| //conf config.URL |
| func (r *BaseRegistry) register(c common.URL) error { | ||
| var ( | ||
| err error | ||
| //revision string |
|
|
||
| params.Add("pid", processID) | ||
| params.Add("ip", localIP) | ||
| //params.Add("timeout", fmt.Sprintf("%d", int64(r.Timeout)/1e6)) |
| // Dubbo java consumer to start looking for the provider url,because the category does not match, | ||
| // the provider will not find, causing the consumer can not start, so we use consumers. | ||
| // DubboRole = [...]string{"consumer", "", "", "provider"} | ||
| // params.Add("category", (RoleType(PROVIDER)).Role()) |
| ) | ||
|
|
||
| // ZookeeperClient ... |
| ) | ||
|
|
||
| import ( | ||
| "github.com/apache/dubbo-go/common/logger" | ||
| "github.com/apache/dubbo-go/remoting" | ||
| ) | ||
|
|
||
| // ZkEventListener ... |
| ) | ||
|
|
||
| // Options ... |
| @@ -36,18 +36,23 @@ import ( | |||
| zk "github.com/apache/dubbo-go/remoting/zookeeper" | |||
| ) | |||
|
|
|||
| // RegistryDataListener ... | |||
flycash
reviewed
Feb 9, 2020
| return perrors.Errorf("@c{%v} type is not referencer or provider", c) | ||
| } | ||
| encodedURL = url.QueryEscape(rawURL) | ||
| dubboPath = strings.ReplaceAll(dubboPath, "$", "%24") |
There was a problem hiding this comment.
I don't understand why not use url.QueryEscape for dubboPath?
| logger.Errorf("facadeBasedRegistry.CreatePath(path{%s}) = error{%#v}", dubboPath, perrors.WithStack(err)) | ||
| return "", "", perrors.WithMessagef(err, "facadeBasedRegistry.CreatePath(path:%s)", dubboPath) | ||
| } | ||
| params.Add("anyhost", "true") |
|
|
||
| params.Add("side", (common.RoleType(common.PROVIDER)).Role()) | ||
|
|
||
| if len(c.Methods) == 0 { |
There was a problem hiding this comment.
if len(c.Methods) != 0 { ...}????
| } | ||
| dubboPath = fmt.Sprintf("/dubbo/%s/%s", r.service(c), common.DubboNodes[common.PROVIDER]) | ||
| r.cltLock.Lock() | ||
| err = r.facadeBasedRegistry.CreatePath(dubboPath) |
There was a problem hiding this comment.
Why should we create provider's path here?
|
|
||
| params.Add("protocol", c.Protocol) | ||
| params.Add("category", (common.RoleType(common.CONSUMER)).String()) | ||
| params.Add("dubbo", "dubbogo-consumer-"+constant.Version) |
There was a problem hiding this comment.
params.Add("dubbo", "dubbo-provider-golang-"+constant.Version) but here is lack of golang. Is that right??
|
|
||
| // sleepWait... | ||
| func sleepWait(n int) { | ||
| wait := time.Duration((n + 1) * 2e8) |
There was a problem hiding this comment.
2e8 is hard to understand, please define a constant.
| return | ||
| } | ||
| logger.Warnf("getListener() = err:%v", perrors.WithStack(err)) | ||
| time.Sleep(time.Duration(RegistryConnDelay) * time.Second) |
There was a problem hiding this comment.
Why not just define the RegistryConnDelay as time.Duration(3* time.Second)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: