-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod:refactor to add base_registry #348
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #348 +/- ##
===========================================
- Coverage 67.65% 67.14% -0.51%
===========================================
Files 123 145 +22
Lines 7317 7692 +375
===========================================
+ Hits 4950 5165 +215
- Misses 1894 2037 +143
- Partials 473 490 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test it end to end? Or run the samples?
Can you remove the recursive logic from the zookeeper registry center in this PR,distinguish from configuration center😛😘 |
Yes,I run it in dubbo-samples |
I think it will be another pr. We need to create a new pull request to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but need some comment for registry/base_registry.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: