-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry/zk):url encode zkpath #283
Conversation
6acbb2f
to
4fcddf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had checked codes using the zkPath. It seems that we don't need to decode the zkPath when we get the zkPath. Right?
4fcddf6
to
54db106
Compare
@flycash yes, just for zk registry |
54db106
to
c0839f0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #283 +/- ##
===========================================
+ Coverage 65.52% 66.34% +0.81%
===========================================
Files 111 111
Lines 7063 7065 +2
===========================================
+ Hits 4628 4687 +59
+ Misses 1978 1919 -59
- Partials 457 459 +2
Continue to review full report at Codecov.
|
I had checked codes using the zkPath too. we use zkPath to registry and get children node,so it seems that no need to decode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I checked java version. There is method named 'encoded' in URL.java and it called by ZookeeperRegistry for zkPath encode. Though I have not received any issue about this problem...Maybe it is encoded by zk golang client. |
@zouyx for consistent with java impl. Besides, grpc need this decode method to resolve "$" for inner class |
What this PR does:
be consistent with java impl, support url encoder for zkpath