Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: add SetLoggerLevel #271

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

add SetLoggerLevel to dynamically modify logger level.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-io
Copy link

Codecov Report

Merging #271 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
+ Coverage    66.38%   66.43%   +0.05%     
===========================================
  Files          111      111              
  Lines         7038     7047       +9     
===========================================
+ Hits          4672     4682      +10     
+ Misses        1907     1905       -2     
- Partials       459      460       +1
Impacted Files Coverage Δ
common/logger/logger.go 94.82% <100%> (+11.15%) ⬆️
config_center/apollo/impl.go 84.41% <0%> (-2.6%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4014c59...88e3a7d. Read the comment docs.

@AlexStocks
Copy link
Contributor

@pantianying pls review this pr.

Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit e6d7c04 into apache:develop Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants