Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BUG: The generic filter and default reference filters lack ',' #260

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

flycash
Copy link
Member

@flycash flycash commented Nov 23, 2019

What this PR does:
The lack of ',' between generic filter and default reference filters
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #260 into develop will decrease coverage by 0.55%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #260      +/-   ##
===========================================
- Coverage    66.17%   65.62%   -0.56%     
===========================================
  Files          111      111              
  Lines         7042     7042              
===========================================
- Hits          4660     4621      -39     
- Misses        1923     1964      +41     
+ Partials       459      457       -2
Impacted Files Coverage Δ
config/reference_config.go 80.89% <0%> (ø) ⬆️
protocol/dubbo/pool.go 57.86% <0%> (-15.74%) ⬇️
protocol/dubbo/listener.go 51.19% <0%> (-10.72%) ⬇️
protocol/dubbo/codec.go 76.47% <0%> (-5.89%) ⬇️
protocol/dubbo/readwriter.go 67.9% <0%> (-2.47%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️
remoting/zookeeper/client.go 64.45% <0%> (+0.57%) ⬆️
registry/etcdv3/registry.go 51.51% <0%> (+1.01%) ⬆️
remoting/zookeeper/listener.go 47.93% <0%> (+1.03%) ⬆️
config_center/zookeeper/listener.go 86.95% <0%> (+4.34%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f25df1...a420214. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit 71552be into apache:develop Nov 24, 2019
@flycash flycash deleted the bug/GenericMergeFilter branch January 10, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants