-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Gracefully shutdown #255
Conversation
2fc89fa
to
af9741a
Compare
It seems that the syscall.SIGEMT cannot be found in CI. |
I'm sorry that I had merge master and bring its change list into this PR |
Codecov Report
@@ Coverage Diff @@
## develop #255 +/- ##
==========================================
- Coverage 66.24% 65.45% -0.8%
==========================================
Files 108 111 +3
Lines 6903 7043 +140
==========================================
+ Hits 4573 4610 +37
- Misses 1879 1978 +99
- Partials 451 455 +4
Continue to review full report at Codecov.
|
14dec2f
to
d7b5f50
Compare
All comments had been fixed and I've tested it end to end again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
What this PR does:
Gracefully shutdown. The steps are:
Which issue(s) this PR fixes:
Fixes #239
Special notes for your reviewer:
Please check the order of releasing resources.
Does this PR introduce a user-facing change?: