-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: AccessLogFilter support #214
Ftr: AccessLogFilter support #214
Conversation
1a0e3ec
to
c5082fd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #214 +/- ##
===========================================
+ Coverage 65.16% 65.98% +0.81%
===========================================
Files 94 95 +1
Lines 6399 6511 +112
===========================================
+ Hits 4170 4296 +126
+ Misses 1792 1774 -18
- Partials 437 441 +4
Continue to review full report at Codecov.
|
6657456
to
db80eae
Compare
db80eae
to
9c4ae4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you test in the examples for your feature?
How to start this filter? |
@fangyincheng should the examples be placed in dubbogo-examples? |
yes |
It's a default filter in Java. But if the user does not specify the value of "accesslog" to store the access log. It won't do anything. |
you are right. Pls do it. |
done, pls review that |
…nts of acccess_log_filter
5ffe461
to
2fa5a79
Compare
568e015
to
8600f70
Compare
LGTM |
@fangyincheng u recheck it and merge it, pls. |
8600f70
to
25c3bf9
Compare
7d01558
to
ec06f21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Add AccessLogFilter
Which issue(s) this PR fixes:
Ftr: AccessLogFilter support
Fixes #
Special notes for your reviewer:
Please review the code about channel and file operation carefully. I'm new to Golang.
Does this PR introduce a user-facing change?: