Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/adaptive-service: deadlock caused by rwMutex in limiter mapper #2053

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

CoolIceV
Copy link
Contributor

What this PR does:
Fix deadlock caused by rwMutex in limiter mapper.

Which issue(s) this PR fixes:
Fixes #2038

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

Codecov Report

Merging #2053 (a0503c6) into 3.0 (33a2901) will not change coverage.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##              3.0    #2053   +/-   ##
=======================================
  Coverage   44.66%   44.66%           
=======================================
  Files         283      283           
  Lines       17108    17108           
=======================================
  Hits         7642     7642           
  Misses       8658     8658           
  Partials      808      808           
Impacted Files Coverage Δ
config/config_loader.go 17.56% <0.00%> (ø)
config/graceful_shutdown.go 3.88% <0.00%> (ø)
config/service_config.go 53.04% <0.00%> (ø)
registry/protocol/protocol.go 72.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit d924219 into apache:3.0 Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants