-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use notifyAll insteadOf notify for listener events notify #2043
Conversation
@chickenlj PTAL~ |
Please take a look at the build and test failures. |
@chickenlj Hi I've passed Do you have any idea how to fix this? |
IMO, please try to checkout 3.0 branch and pull the latest commits, then rebase the 3.0 branch to UPDATE 1: After rebased, run |
0bb9886
to
16faa53
Compare
Probably because there are failures on the 3.0 base branch. We need to fix failures there first. |
golangci-lint passed after rebased this PR #2047, will check the ut failure later |
df3f2e6
to
137a190
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0 #2043 +/- ##
==========================================
+ Coverage 44.59% 44.68% +0.08%
==========================================
Files 283 283
Lines 17106 17108 +2
==========================================
+ Hits 7629 7645 +16
+ Misses 8671 8655 -16
- Partials 806 808 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: LexusLee<[email protected]>
137a190
to
eea7a03
Compare
Signed-off-by: xiaoxu [email protected]
What this PR does:
Notify one after one
might have performance issues, this PR makes serviceListeners notify events concurrently and do not wait for notification complated.I am wondering if it's needed to add a sync.WaitGroup after NotifyAll to wait notification completed or not.
Which issue(s) this PR fixes:
Fixes #2030
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed