Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token support #202

Merged
merged 5 commits into from
Sep 18, 2019
Merged

Add token support #202

merged 5 commits into from
Sep 18, 2019

Conversation

xujianhai666
Copy link
Member

What this PR does:
Add token support


@xujianhai666 xujianhai666 force-pushed the feat-tokencs branch 5 times, most recently from 7a0101d to f35a81f Compare September 13, 2019 15:41
protocol/dubbo/dubbo_invoker.go Outdated Show resolved Hide resolved
filter/impl/token_filter.go Show resolved Hide resolved
filter/impl/token_filter.go Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #202 into develop will increase coverage by 0.05%.
The diff coverage is 68.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #202      +/-   ##
===========================================
+ Coverage    65.22%   65.28%   +0.05%     
===========================================
  Files           95       96       +1     
  Lines         6416     6444      +28     
===========================================
+ Hits          4185     4207      +22     
- Misses        1791     1798       +7     
+ Partials       440      439       -1
Impacted Files Coverage Δ
common/url.go 68.97% <0%> (-1.64%) ⬇️
protocol/dubbo/dubbo_invoker.go 84.09% <100%> (+1.16%) ⬆️
config/service_config.go 65.11% <100%> (+0.83%) ⬆️
filter/impl/token_filter.go 87.5% <87.5%> (ø)
protocol/jsonrpc/server.go 61.3% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef14088...0888326. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

please merge newest code.

@gaoxinge
Copy link

LGTM.

@AlexStocks AlexStocks merged commit a977cc9 into apache:develop Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants