-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolve placeholder #2014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
很不错的PR,不过建议你可以看下这个代码:config#L33-L70 可以递归解析还可以设置默认值eg:${dubbo.provider.filter:nacos}
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
+ Coverage 44.40% 44.67% +0.27%
==========================================
Files 283 283
Lines 17067 17133 +66
==========================================
+ Hits 7578 7654 +76
+ Misses 8687 8672 -15
- Partials 802 807 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What this PR does:
resolve placeholder
${xxx:defaultValue}
Which issue(s) this PR fixes:
Fixes #1983
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed