Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proto): fix getting attributes issue #1968

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Jul 12, 2022

RPCInvocation::GetAttributeWithDefaultValue() has a typo which couldn't
get attributes correctly, this PR fixes that issue.

Signed-off-by: Xuewei Niu [email protected]

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

RPCInvocation::GetAttributeWithDefaultValue() has a typo which couldn't
get attributes correctly, this PR fixes that issue.

Signed-off-by: Xuewei Niu <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1968 (0d7edc2) into master (f164c81) will decrease coverage by 0.07%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   44.48%   44.41%   -0.08%     
==========================================
  Files         284      283       -1     
  Lines       17038    17023      -15     
==========================================
- Hits         7580     7560      -20     
- Misses       8654     8656       +2     
- Partials      804      807       +3     
Impacted Files Coverage Δ
cluster/cluster/base/cluster_invoker.go 24.44% <ø> (ø)
cluster/cluster/broadcast/cluster_invoker.go 80.00% <ø> (ø)
cluster/cluster/failback/cluster_invoker.go 75.82% <ø> (ø)
cluster/cluster/failover/cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster/failsafe/cluster_invoker.go 81.81% <ø> (ø)
cluster/cluster/forking/cluster_invoker.go 58.33% <ø> (ø)
cluster/loadbalance/p2c/loadbalance.go 76.36% <ø> (ø)
cluster/loadbalance/ringhash/ringhash.go 63.33% <ø> (ø)
cluster/router/tag/match.go 90.69% <ø> (ø)
cluster/router/tag/router.go 59.64% <ø> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abbc2e...0d7edc2. Read the comment docs.

@AlexStocks AlexStocks merged commit de6fcfb into apache:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants