-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ftr] Enhance ServiceDefinition in MetadataService #1963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls fix the ci failure. |
Codecov Report
@@ Coverage Diff @@
## 3.0 #1963 +/- ##
==========================================
- Coverage 44.96% 44.59% -0.37%
==========================================
Files 287 283 -4
Lines 17135 17101 -34
==========================================
- Hits 7704 7626 -78
- Misses 8618 8670 +52
+ Partials 813 805 -8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
cjphaha
reviewed
Jul 19, 2022
Leospard
changed the title
[WIP] Enhance ServiceDefinition in MetadataService
[Ftr] Enhance ServiceDefinition in MetadataService
Jul 29, 2022
AlexStocks
reviewed
Aug 4, 2022
AlexStocks
reviewed
Aug 5, 2022
justxuewei
approved these changes
Aug 5, 2022
AlexStocks
approved these changes
Aug 6, 2022
zhaoyunxing92
approved these changes
Aug 10, 2022
CoolIceV
pushed a commit
to CoolIceV/dubbo-go
that referenced
this pull request
Aug 31, 2022
* Add FullServiceDefinition struct * mark the place waiting to be changed in PublishServiceDefinition * add test about FullServiceDefinition * modify format * modify comment * format the code * split one long line
CoolIceV
added a commit
to CoolIceV/dubbo-go
that referenced
this pull request
Sep 9, 2022
* feat(adaptive service): auto concurrency limiter * feat(adaptive service): auto concurrency limiter * feat(adaptive service): auto concurrency limiter * feat(adaptive service): auto concurrency limiter * feat(adaptive service): auto concurrency limiter * feat(adaptive service): p2c weight * build(deps): bump go.opentelemetry.io/otel/trace from 1.8.0 to 1.9.0 (apache#2010) Bumps [go.opentelemetry.io/otel/trace](https://github.com/open-telemetry/opentelemetry-go) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.8.0...v1.9.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/trace dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump go.opentelemetry.io/otel from 1.8.0 to 1.9.0 (apache#2013) Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.8.0...v1.9.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/nacos-group/nacos-sdk-go (apache#2012) Bumps [github.com/nacos-group/nacos-sdk-go](https://github.com/nacos-group/nacos-sdk-go) from 1.1.1 to 1.1.2. - [Release notes](https://github.com/nacos-group/nacos-sdk-go/releases) - [Commits](nacos-group/nacos-sdk-go@v1.1.1...v1.1.2) --- updated-dependencies: - dependency-name: github.com/nacos-group/nacos-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(shotdown):fix shotdown InternalSignal default value * test(shutdown):add shutdown internal signal test * [Ftr] Enhance ServiceDefinition in MetadataService (apache#1963) * Add FullServiceDefinition struct * mark the place waiting to be changed in PublishServiceDefinition * add test about FullServiceDefinition * modify format * modify comment * format the code * split one long line * ignore goenv * build(deps): bump github.com/dubbogo/grpc-go from 1.42.9 to 1.42.10 (apache#2019) Bumps [github.com/dubbogo/grpc-go](https://github.com/dubbogo/grpc-go) from 1.42.9 to 1.42.10. - [Release notes](https://github.com/dubbogo/grpc-go/releases) - [Commits](dubbogo/grpc-go@v1.42.9...v1.42.10) --- updated-dependencies: - dependency-name: github.com/dubbogo/grpc-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * upgrade grpc-go version v1.42.9 -> v1.42.10 (apache#2017) * Revert 2014 resolve placeholder (apache#2023) * resolve placeholder * build(deps): bump github.com/knadh/koanf from 1.4.2 to 1.4.3 (apache#2027) Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.4.2 to 1.4.3. - [Release notes](https://github.com/knadh/koanf/releases) - [Commits](knadh/koanf@v1.4.2...v1.4.3) --- updated-dependencies: - dependency-name: github.com/knadh/koanf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(adaptive service): p2c weight * feat(adaptive service): ema * fix license * fix time * auto concurrency limiter * auto concurrency limiter * auto concurrency limiter Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zhaoyunxing <[email protected]> Co-authored-by: Leo Shen <[email protected]> Co-authored-by: AlexStocks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Enhance ServiceDefinition in MetadataService, which means provide full parameters in Servicedefinition.
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed