Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix bug when creating metrics objects concurrently #1961

Merged
merged 3 commits into from
Jul 17, 2022

Conversation

CoolIceV
Copy link
Contributor

@CoolIceV CoolIceV commented Jul 8, 2022

What this PR does:
fix bug when creating metrics objects concurrently

Which issue(s) this PR fixes:
Fixes #1953

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #1961 (47f1947) into 3.0 (de6fcfb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #1961      +/-   ##
==========================================
- Coverage   44.32%   44.31%   -0.02%     
==========================================
  Files         283      283              
  Lines       17067    17041      -26     
==========================================
- Hits         7565     7551      -14     
+ Misses       8696     8686      -10     
+ Partials      806      804       -2     
Impacted Files Coverage Δ
metrics/prometheus/reporter.go 30.25% <0.00%> (+2.20%) ⬆️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
...nstance/random/random_service_instance_selector.go 66.66% <0.00%> (ø)
cluster/loadbalance/p2c/loadbalance.go 80.00% <0.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6fcfb...47f1947. Read the comment docs.

@AlexStocks
Copy link
Contributor

@Mulavar pls review agaiin.

@AlexStocks AlexStocks merged commit 2f8dc5a into apache:3.0 Jul 17, 2022
@CoolIceV CoolIceV deleted the fix/metrics branch August 9, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants