-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Grpc based Health check. #1935
Conversation
5b55641
to
c47b0d2
Compare
* Use grpc health check proto, ref: https://github.com/grpc-ecosystem/grpc-health-probe * Fix test config * Current health check only support triple protocol.
) | ||
|
||
// Server implements `service Health`. | ||
type XXX_healthServer struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为何是 XXX 开头?替换成 Dubbogo 如何?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得应该是可以的,我是参考了以前grpc reflection的server的命名方法。@LaurenceLiZhixin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议换成Dubbogo开头吧,不要使用下划线。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得应该是可以的,我是参考了以前grpc reflection的server的命名方法。@LaurenceLiZhixin
这么说吧,XXX 开头我以前确实见过,那是 protobuf 根据 .proto 文件生成的机器代码,不是给人读的。
) | ||
|
||
// Server implements `service Health`. | ||
type XXX_healthServer struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为何要义 XXX 开头命名?
Codecov Report
@@ Coverage Diff @@
## 3.0 #1935 +/- ##
==========================================
- Coverage 44.95% 44.40% -0.56%
==========================================
Files 287 284 -3
Lines 17130 17038 -92
==========================================
- Hits 7701 7565 -136
- Misses 8616 8670 +54
+ Partials 813 803 -10
Continue to review full report at Codecov.
|
What this PR does:
Which issue(s) this PR fixes:
Fixes ##1904
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed