-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use summary type to observe p99 #1875
Conversation
Signed-off-by: jyz0309 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 3.0 #1875 +/- ##
==========================================
- Coverage 46.87% 44.82% -2.06%
==========================================
Files 298 283 -15
Lines 17178 16933 -245
==========================================
- Hits 8053 7591 -462
- Misses 8272 8533 +261
+ Partials 853 809 -44
Continue to review full report at Codecov.
|
Signed-off-by: jyz0309 <[email protected]>
Signed-off-by: jyz0309 <[email protected]>
Good, and it's better to add Max Age configuration at and export the configuration to dubbogo.yaml , metrics config struct of root config. |
Can you tell me how to export configuration to dubbogo.yaml? It will help a lot if there is a sample code. @LaurenceLiZhixin |
Add a config field named "RTSummaryMaxAge" of metrics config here: https://github.com/apache/dubbo-go/blob/master/config/metric_config.go#L31 |
Signed-off-by: jyz0309 <[email protected]>
Signed-off-by: jyz0309 <[email protected]>
Signed-off-by: jyz0309 <[email protected]>
Signed-off-by: jyz0309 [email protected]
What this PR does:
Change metric type to observe RT P99 value.
Which issue(s) this PR fixes:
None.
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed