fix: limit rpc package data size by user's config rather than DEFAULT_LEN. #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #1848 +/- ##
==========================================
- Coverage 46.76% 46.70% -0.06%
==========================================
Files 298 298
Lines 17178 17200 +22
==========================================
Hits 8034 8034
- Misses 8291 8310 +19
- Partials 853 856 +3
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Apr 20, 2022
|
在日志中，提示下，如果通信的对端是 dubbo java，则dubbo java 无法处理超过 DEFAULT_LEN(8MiB) 的包。 |
…_LEN * Dubbo recommand package data length not greater than 8MiB. * If package data length greater than 8MiB, generate warnning. * If package data lenght greater than user's config, generate exception. Signed-off-by: stonex <[email protected]>
AlexStocks
reviewed
Apr 20, 2022
| return nil, perrors.Errorf("Data length %d too large, max payload %d", pkgLen, DEFAULT_LEN) | ||
| if pkgLen > int(DEFAULT_LEN) { // recommand 8M | ||
| logger.Warnf("Data length %d too large, recommand max payload %d. "+ | ||
| "Dubbo java can't handle the package which size greater than %d!!!", pkgLen, DEFAULT_LEN, DEFAULT_LEN) |
There was a problem hiding this comment.
which size greater than = whose size is greater than
pherzheyu
approved these changes
May 1, 2022
LaurenceLiZhixin
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Signed-off-by: stonex [email protected]
Which issue(s) this PR fixes:
Fixes #1839
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed