Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xds log use dubbogo logger #1846

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Apr 19, 2022

What this PR does:

let XDS module use dubbogo logger.

Which issue(s) this PR fixes:

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

Codecov Report

Merging #1846 (3c45a7f) into 3.0 (f504fee) will decrease coverage by 0.01%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##              3.0    #1846      +/-   ##
==========================================
- Coverage   46.76%   46.75%   -0.02%     
==========================================
  Files         298      295       -3     
  Lines       17178    17172       -6     
==========================================
- Hits         8033     8028       -5     
+ Misses       8291     8290       -1     
  Partials      854      854              
Impacted Files Coverage Δ
xds/balancer/clusterimpl/clusterimpl.go 1.70% <0.00%> (ø)
xds/balancer/clusterimpl/picker.go 0.00% <0.00%> (ø)
xds/balancer/priority/balancer.go 4.30% <0.00%> (ø)
xds/balancer/priority/balancer_child.go 0.00% <0.00%> (ø)
xds/balancer/priority/balancer_priority.go 0.00% <0.00%> (ø)
xds/balancer/ringhash/picker.go 0.00% <0.00%> (ø)
xds/balancer/ringhash/ringhash.go 2.50% <0.00%> (ø)
xds/client/bootstrap/bootstrap.go 59.11% <66.66%> (ø)
remoting/xds/client.go 56.00% <100.00%> (ø)
xds/utils/serviceconfig/serviceconfig.go 89.18% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2373592...3c45a7f. Read the comment docs.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit ae8893a into apache:3.0 Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants