Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit rpc package data size by user's config rather than DEFAULT_LEN. #1845

Closed
wants to merge 1 commit into from

Conversation

sheny1xuan
Copy link
Contributor

What this PR does:

  • Dubbo recommand package data length not greater than 8MiB.
  • If package data length greater than 8MiB, generate warnning.
  • If package data lenght greater than user's config, generate exception.

Signed-off-by: stonex [email protected]

Which issue(s) this PR fixes:
Fixes #1839

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

…_LEN.

  * Dubbo recommand package data length not greater than 8MiB.
  * If package data length greater than 8MiB, generate warnning.
  * If package data lenght greater than user's config, generate exception.

Signed-off-by: stonex <[email protected]>
@LaurenceLiZhixin
Copy link
Contributor

@sheny1xuan 提交代码到3.0分支。

@sheny1xuan
Copy link
Contributor Author

@sheny1xuan 提交代码到3.0分支。

好的,那这个pr我关掉了

@sheny1xuan sheny1xuan closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: the package size should not be greater than 8MiB
2 participants