add unit test #1693
Merged
add unit test #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Dec 30, 2021
AlexStocks
reviewed
Dec 30, 2021
| assert.Equal(tn.t, "2233", e.Service.Port) | ||
| tn.wg.Done() | ||
| } | ||
| func (tn *testNotify) NotifyAll([]*registry.ServiceEvent, func()) { |
There was a problem hiding this comment.
这个函数上面留一个空行。函数之间不要连在一起。
AlexStocks
approved these changes
Dec 30, 2021
|
单元测试未通过。本地跑一下，不要依赖真实的注册组件。 @A-Wanderer |
Codecov Report
@@ Coverage Diff @@
## 3.0 #1693 +/- ##
==========================================
+ Coverage 41.31% 42.64% +1.32%
==========================================
Files 255 255
Lines 14705 14719 +14
==========================================
+ Hits 6076 6277 +201
+ Misses 7930 7725 -205
- Partials 699 717 +18
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Jan 13, 2022
justxuewei
reviewed
Jan 14, 2022
cjphaha
approved these changes
Jan 16, 2022
LaurenceLiZhixin
requested changes
Jan 17, 2022
A-Wanderer
force-pushed
the
add-ut
branch
3 times, most recently
from
12ea66b to
f4784c0
Compare
LaurenceLiZhixin
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: