feature-graceful-shutdwon #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo：
|
|
run |
|
license, imports block 问题已经解决，ut问题需要再看下，位置 registry/protocol/protocol_test.go:141 |
added 2 commits
January 5, 2022 17:28
Codecov Report
@@ Coverage Diff @@
## 3.0 #1675 +/- ##
==========================================
+ Coverage 41.31% 41.39% +0.08%
==========================================
Files 255 256 +1
Lines 14705 14778 +73
==========================================
+ Hits 6076 6118 +42
- Misses 7930 7960 +30
- Partials 699 700 +1
Continue to review full report at Codecov.
|
|
我在调试完善，先不要合并 |
AlexStocks
approved these changes
Jan 16, 2022
Mulavar
reviewed
Jan 16, 2022
LaurenceLiZhixin
approved these changes
Jan 17, 2022
Mulavar
approved these changes
Jan 17, 2022
binbin0325
reviewed
Jan 17, 2022
| @@ -33,11 +33,11 @@ func SetFilter(name string, v func() filter.Filter) { | |||
| } | |||
|
|
|||
| // GetFilter finds the filter extension with @name | |||
| func GetFilter(name string) filter.Filter { | |||
| func GetFilter(name string) (filter.Filter, bool) { | |||
| timeout := shutdownConfig.GetStepTimeout() | ||
| if timeout <= 0 { | ||
| return | ||
| } | ||
| deadline := time.Now().Add(timeout) | ||
|
|
||
| for time.Now().Before(deadline) && !shutdownConfig.RequestsFinished { | ||
| for time.Now().Before(deadline) && shutdownConfig.ConsumerActiveCount > 0 { |
There was a problem hiding this comment.
shutdownConfig.ConsumerActiveCount 需要用atomic.Load吧
| @@ -124,6 +124,16 @@ func GetApplicationConfig() *ApplicationConfig { | |||
| return rootConfig.Application | |||
| } | |||
|
|
|||
| func GetShutDown() *ShutdownConfig { | |||
There was a problem hiding this comment.
这样写也许更整洁点
if err := check(); err == nil && rootConfig.Shutdown != nil {
return rootConfig.Shutdown
}
return NewShutDownConfigBuilder().Build()
| } | ||
| deadline := time.Now().Add(timeout) | ||
|
|
||
| for time.Now().Before(deadline) && shutdownConfig.ProviderActiveCount > 0 { |
| reg, err = extension.GetRegistry(registryUrl.Protocol, registryUrl) | ||
| if err != nil { | ||
| logger.Errorf("Registry can not connect success, program is going to panic.Error message is %s", err.Error()) | ||
| panic(err.Error()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1664
of 3.0.1 milestone #1685