add:support file extension #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyunxing92
changed the title
Codecov Report
@@ Coverage Diff @@
## 3.0 #1626 +/- ##
==========================================
+ Coverage 40.94% 41.06% +0.11%
==========================================
Files 252 252
Lines 14443 14445 +2
==========================================
+ Hits 5914 5932 +18
+ Misses 7848 7830 -18
- Partials 681 683 +2
Continue to review full report at Codecov.
|
|
记得在samples 仓库里给出对应例子。 @zhaoyunxing92 |
LaurenceLiZhixin
approved these changes
Dec 1, 2021
PhilYue
approved these changes
Dec 1, 2021
PhilYue
reviewed
Dec 1, 2021
| @@ -155,11 +161,11 @@ func userHomeDir() string { | |||
|
|
|||
| // checkGenre check Genre | |||
| func checkGenre(genre string) error { | |||
| genres := []string{"json", "toml", "yaml", "yml"} | |||
| genres := []string{"json", "toml", "yaml", "yml", "properties"} | |||
| sort.Strings(genres) | |||
| idx := sort.SearchStrings(genres, genre) | |||
| if genres[idx] != genre { | |||
There was a problem hiding this comment.
这里的判断是不是需要判断边界情况 idx == len(genres) || genres[idx] != genre
There was a problem hiding this comment.
源码里面就是一个二分搜索，不会存在-1的情况
func Search(n int, f func(int) bool) int {
// Define f(-1) == false and f(n) == true.
// Invariant: f(i-1) == false, f(j) == true.
i, j := 0, n
for i < j {
h := int(uint(i+j) >> 1) // avoid overflow when computing h
// i ≤ h < j
if !f(h) {
i = h + 1 // preserves f(i-1) == false
} else {
j = h // preserves f(j) == true
}
}
// i == j, f(i-1) == false, and f(j) (= f(i)) == true => answer is i.
return i
}
|
这个 pr 我看标识是 WIP，为啥都有两个 approve 了？ |
我的锅，之前没注意到 |
zhaoyunxing92
changed the title
AlexStocks
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
配置中心支持自定义文件类型解析器，目前支持
json、yaml、properties、yml、toml五种文件类型配置Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: