Fix: Make the Consumer config property Check available
#1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a109967.
…ache#1387) Bumps [github.com/dubbogo/gost](https://github.com/dubbogo/gost) from 1.11.14 to 1.11.16. - [Release notes](https://github.com/dubbogo/gost/releases) - [Commits](dubbogo/gost@v1.11.14...v1.11.16) --- updated-dependencies: - dependency-name: github.com/dubbogo/gost dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pache#1386) Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.26.0 to 1.27.1. - [Release notes](https://github.com/protocolbuffers/protobuf-go/releases) - [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash) - [Commits](protocolbuffers/protobuf-go@v1.26.0...v1.27.1) --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (apache#1383) Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.0-alpha.0 to 3.5.0. - [Release notes](https://github.com/etcd-io/etcd/releases) - [Changelog](https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md) - [Commits](etcd-io/etcd@v3.5.0-alpha.0...v3.5.0) --- updated-dependencies: - dependency-name: go.etcd.io/etcd/client/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…se the Consumer config when omitted
| @@ -46,7 +46,7 @@ type ReferenceConfig struct { | |||
| pxy *proxy.Proxy | |||
| id string | |||
| InterfaceName string `required:"true" yaml:"interface" json:"interface,omitempty" property:"interface"` | |||
| Check *bool `default:"true" yaml:"check" json:"check,omitempty" property:"check"` | |||
| Check *bool `yaml:"check" json:"check,omitempty" property:"check"` | |||
There was a problem hiding this comment.
为了让 Reference Config 的 check 延用 Consumer Config 的 check 配置，
如果 reference 的 check 有默认值，就没法判断是用户自己配置的还是默认的
|
I would merge master to your repo, and ci may pass. |
Codecov Report
@@ Coverage Diff @@
## 3.0 #1568 +/- ##
=======================================
Coverage 41.83% 41.84%
=======================================
Files 258 258
Lines 15115 15117 +2
=======================================
+ Hits 6324 6325 +1
- Misses 8049 8050 +1
Partials 742 742
Continue to review full report at Codecov.
|
LaurenceLiZhixin
approved these changes
Nov 9, 2021
AlexStocks
approved these changes
Nov 9, 2021
justxuewei
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Make the Consumer config property
CheckavailableWhich issue(s) this PR fixes:
Fixes #1555
Special notes for your reviewer:
checkuse the Consumer config when omitted.checkDoes this PR introduce a user-facing change?:
NONE